chore(blockifier): delete redundant test (#6167)

* chore(blockifier): update test_syscall_gas_cost_calculation

* chore(blockifier): delete redundant test

Author: dorimedini-starkware

crates/blockifier/src/test_utils.rs

@@ -361,15 +361,6 @@ pub fn create_deploy_entry_point(
     }
 }
 
-pub fn update_json_value(base: &mut serde_json::Value, update: serde_json::Value) {
-    match (base, update) {
-        (serde_json::Value::Object(base_map), serde_json::Value::Object(update_map)) => {
-            base_map.extend(update_map);
-        }
-        _ => panic!("Both base and update should be of type serde_json::Value::Object."),
-    }
-}
-
 pub fn gas_vector_from_vm_usage(
     vm_usage_in_l1_gas: GasAmount,
     computation_mode: &GasVectorComputationMode,

crates/blockifier/src/test_utils/struct_impls.rs

@@ -10,7 +10,6 @@ use cairo_lang_starknet_classes::casm_contract_class::CasmContractClass;
 use cairo_lang_starknet_classes::contract_class::ContractClass as SierraContractClass;
 #[cfg(feature = "cairo_native")]
 use cairo_native::executor::AotContractExecutor;
-use serde_json::Value;
 use starknet_api::block::BlockInfo;
 use starknet_api::contract_address;
 #[cfg(feature = "cairo_native")]
@@ -25,12 +24,7 @@ use starknet_api::test_utils::{
 };
 
 use crate::blockifier::config::{CairoNativeRunConfig, ContractClassManagerConfig};
-use crate::blockifier_versioned_constants::{
-    GasCosts,
-    OsConstants,
-    VersionedConstants,
-    VERSIONED_CONSTANTS_LATEST_JSON,
-};
+use crate::blockifier_versioned_constants::VersionedConstants;
 use crate::bouncer::{BouncerConfig, BouncerWeights};
 use crate::context::{BlockContext, ChainInfo, FeeTokenAddresses, TransactionContext};
 use crate::execution::call_info::{CallExecution, CallInfo, Retdata};
@@ -47,7 +41,6 @@ use crate::execution::entry_point::{
 use crate::execution::native::contract_class::NativeCompiledClassV1;
 use crate::state::contract_class_manager::ContractClassManager;
 use crate::state::state_api::State;
-use crate::test_utils::update_json_value;
 use crate::transaction::objects::{
     CurrentTransactionInfo,
     DeprecatedTransactionInfo,
@@ -143,21 +136,6 @@ impl VersionedConstants {
     }
 }
 
-impl GasCosts {
-    pub fn create_for_testing_from_subset(subset_of_os_constants: &str) -> Self {
-        let subset_of_os_constants: Value = serde_json::from_str(subset_of_os_constants).unwrap();
-        let mut os_constants: Value =
-            serde_json::from_str::<Value>(VERSIONED_CONSTANTS_LATEST_JSON.as_str())
-                .unwrap()
-                .get("os_constants")
-                .unwrap()
-                .clone();
-        update_json_value(&mut os_constants, subset_of_os_constants);
-        let os_constants: OsConstants = serde_json::from_value(os_constants).unwrap();
-        os_constants.gas_costs
-    }
-}
-
 impl ChainInfo {
     pub fn create_for_testing() -> Self {
         Self {

crates/blockifier/src/versioned_constants_test.rs

@@ -16,34 +16,6 @@ fn all_jsons_in_dir() -> Paths {
     glob(format!("{}/resources/*.json", compile_time_cargo_manifest_dir!()).as_str()).unwrap()
 }
 
-#[test]
-fn test_successful_gas_costs_parsing() {
-    let json_data = r#"
-    {
-        "step_gas_cost": 2,
-        "entry_point_initial_budget": {
-            "step_gas_cost": 3
-        },
-        "syscall_base_gas_cost": {
-            "entry_point_initial_budget": 4,
-            "step_gas_cost": 5
-        },
-        "error_out_of_gas": "An additional field in GasCosts::ADDITIONAL_ALLOWED_NAMES, ignored."
-    }"#;
-    let gas_costs = GasCosts::create_for_testing_from_subset(json_data);
-    let os_constants: Arc<OsConstants> = Arc::new(OsConstants { gas_costs, ..Default::default() });
-    let versioned_constants = VersionedConstants { os_constants, ..Default::default() };
-
-    assert_eq!(versioned_constants.os_constants.gas_costs.base.step_gas_cost, 2);
-    assert_eq!(versioned_constants.os_constants.gas_costs.base.entry_point_initial_budget, 2 * 3); // step_gas_cost * 3.
-
-    // entry_point_initial_budget * 4 + step_gas_cost * 5.
-    assert_eq!(
-        versioned_constants.os_constants.gas_costs.base.syscall_base_gas_cost,
-        6 * 4 + 2 * 5
-    );
-}
-
 /// Assert versioned constants overrides are used when provided.
 #[test]
 fn test_versioned_constants_overrides() {