apollo_compilation_utils: remove dead install_compiler_binary and legacy paths

Remove code that is no longer used after the switch to script-based
compiler installation:

- Remove install_compiler_binary() and legacy_binary_path()
- Remove shared_folder_dir(), target_dir() from paths.rs
- Remove tempfile build-dependency from apollo_compilation_utils
- Update workflow artifact path and BUILD file

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: avi-starkware

.github/workflows/upload_artifacts_workflow.yml

@@ -144,9 +144,12 @@ jobs:
           path: "target/release/native_blockifier.pypy39-pp73-x86_64-linux-gnu.so"
           destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"
 
+      - name: Copy starknet-native-compile for upload
+        run: cp "$HOME/.cargo/bin/starknet-native-compile" target/release/starknet-native-compile
+
       - name: Upload starknet-native-compile to GCP
         id: upload_snc_file
         uses: "google-github-actions/upload-cloud-storage@v2"
         with:
-          path: "target/release/shared_executables/starknet-native-compile"
+          path: "target/release/starknet-native-compile"
           destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"

BUILD

@@ -1,7 +1,7 @@
 # Export the built artifact to allow local builds.
 exports_files([
     "target/release/libnative_blockifier.so",
-    "target/release/shared_executables/starknet-native-compile",
+    "target/release/starknet-native-compile",
     "target/debug/starknet_committer_and_os_cli",
     "target/release/starknet_committer_and_os_cli",
     "target/x86_64-unknown-linux-musl/debug/starknet_committer_and_os_cli",

crates/apollo_compilation_utils/Cargo.toml

@@ -28,7 +28,3 @@ thiserror.workspace = true
 apollo_infra_utils.workspace = true
 assert_matches.workspace = true
 rstest.workspace = true
-
-[build-dependencies]
-apollo_infra_utils.workspace = true
-tempfile.workspace = true

crates/apollo_compilation_utils/src/build_utils.rs

@@ -1,71 +1,6 @@
 use std::path::Path;
 use std::process::Command;
 
-use tempfile::TempDir;
-
-use crate::paths::{legacy_binary_path, shared_folder_dir};
-
-pub fn install_compiler_binary(
-    binary_name: &str,
-    required_version: &str,
-    cargo_install_args: &[&str],
-    out_dir: &std::path::Path,
-) {
-    let binary_path = legacy_binary_path(out_dir, binary_name);
-    match Command::new(&binary_path).args(["--version"]).output() {
-        Ok(binary_version) => {
-            let binary_version = String::from_utf8(binary_version.stdout)
-                .expect("Failed to convert the binary version to a string.");
-            if binary_version.contains(required_version) {
-                println!("The {binary_name} binary is up to date.");
-                return;
-            } else {
-                println!(
-                    "The {binary_name} binary is not up to date. Installing the required version."
-                );
-                std::fs::remove_file(&binary_path).expect("Failed to remove the old binary.");
-            }
-        }
-        Err(_) => {
-            println!("The {binary_name} binary is not installed. Installing the required version.");
-        }
-    }
-
-    let temp_cargo_path = TempDir::new().expect("Failed to create a temporary directory.");
-    let post_install_file_path = temp_cargo_path.path().join("bin").join(binary_name);
-
-    let install_command_status = Command::new("cargo")
-        .args([
-            "install",
-            "--root",
-            temp_cargo_path.path().to_str().expect("Failed to convert cargo_path to str"),
-            "--locked",
-        ])
-        .args(cargo_install_args)
-        .status()
-        .unwrap_or_else(|_| panic!("Failed to install {binary_name}"));
-
-    if !install_command_status.success() {
-        panic!("Failed to install {binary_name}");
-    }
-
-    // Move the '{binary_name}' executable to a shared location.
-    std::fs::create_dir_all(shared_folder_dir(out_dir))
-        .expect("Failed to create shared executables folder");
-    let move_command_status = Command::new("mv")
-        .args([post_install_file_path.as_os_str(), binary_path.as_os_str()])
-        .status()
-        .expect("Failed to perform mv command.");
-
-    if !move_command_status.success() {
-        panic!("Failed to move the {binary_name} binary to the shared folder.");
-    }
-
-    std::fs::remove_dir_all(temp_cargo_path).expect("Failed to remove the cargo directory.");
-
-    println!("Successfully set executable file: {:?}", binary_path.display());
-}
-
 /// Verifies that a compiler binary is installed and has the required version.
 /// Panics with installation instructions if the binary is missing or has the wrong version.
 pub fn verify_compiler_binary(binary_path: &Path, required_version: &str) {

crates/apollo_compilation_utils/src/paths.rs

@@ -1,25 +1,6 @@
-// Note: This module includes path resolution functions that are needed during build and run times.
-// It must not contain functionality that is available in only in one of these modes. Specifically,
-// it must avoid relying on env variables such as 'CARGO_*' or 'OUT_DIR'.
-
-fn target_dir(out_dir: &std::path::Path) -> std::path::PathBuf {
-    out_dir
-        .ancestors()
-        .nth(3)
-        .expect("Failed to navigate up three levels from OUT_DIR")
-        .to_path_buf()
-}
-
-pub fn shared_folder_dir(out_dir: &std::path::Path) -> std::path::PathBuf {
-    target_dir(out_dir).join("shared_executables")
-}
+use std::path::PathBuf;
 
 /// Returns the binary name as a PathBuf. `Command::new` will find it in PATH.
-pub fn binary_path(binary_name: &str) -> std::path::PathBuf {
-    std::path::PathBuf::from(binary_name)
-}
-
-// TODO(Avi): Remove once build.rs callers are gone.
-pub fn legacy_binary_path(out_dir: &std::path::Path, binary_name: &str) -> std::path::PathBuf {
-    shared_folder_dir(out_dir).join(binary_name)
+pub fn binary_path(binary_name: &str) -> PathBuf {
+    PathBuf::from(binary_name)
 }