workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 95bc227, add v0 alias

Picks up the keccak builtin simulation in the privacy bootloader
(starkware-libs/proving-utils#342 by @yuvalg) plus the regenerated circuit
verifier constants (starkware-libs/proving-utils#343), allowing virtual-OS
proofs that exercise the keccak builtin to be generated and verified.

The rev points at Yoni-Starkware/proving-utils because the relevant fix
commits are not yet merged upstream; switch to a starkware-libs rev once
proving-utils#343 (and its base PRs #341, #342) land.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Yoni-Starkware

Cargo.lock

@@ -334,8 +334,9 @@ paste = "1.0.15"
 phf = "0.11"
 pretty_assertions = "1.4.0"
 primitive-types = "0.12.1"
-privacy-circuit-verify = { git = "https://github.com/starkware-libs/proving-utils", rev = "580135e" }
-privacy-prove = { git = "https://github.com/starkware-libs/proving-utils", rev = "580135e" }
+privacy-circuit-verify-v0 = { package = "privacy-circuit-verify", git = "https://github.com/starkware-libs/proving-utils", rev = "580135e" }
+privacy-circuit-verify-v1 = { package = "privacy-circuit-verify", git = "https://github.com/starkware-libs/proving-utils", rev = "039e52c" }
+privacy-prove = { git = "https://github.com/starkware-libs/proving-utils", rev = "039e52c" }
 proc-macro2 = "1.0"
 prometheus-parse = "0.2.4"
 prost = "0.12.1"

Cargo.toml

@@ -11,7 +11,8 @@ workspace = true
 
 [dependencies]
 apollo_sizeof.workspace = true
-privacy-circuit-verify.workspace = true
+privacy-circuit-verify-v0.workspace = true
+privacy-circuit-verify-v1.workspace = true
 serde = { workspace = true, features = ["derive"] }
 starknet-types-core.workspace = true
 starknet_api.workspace = true

crates/apollo_transaction_converter/resources/example_proof.bin

@@ -3,7 +3,6 @@
 use std::sync::Arc;
 
 use apollo_sizeof::SizeOf;
-use privacy_circuit_verify::{verify_recursive_circuit, PrivacyProofOutput};
 use serde::{Deserialize, Serialize};
 use starknet_api::transaction::fields::{Proof, ProofFacts, ProofVersion};
 use starknet_types_core::felt::Felt;
@@ -124,25 +123,41 @@ pub fn reconstruct_output_preimage(
 
 /// Verifies a submitted proof against the proof facts using the circuit verifier.
 ///
-/// Accepts either V0 (legacy) or V1 (current) proof versions. Both currently resolve to the same
-/// upstream circuit revision. When the V1 circuit revision is bumped, V0 verification should be
-/// routed to a `privacy-circuit-verify-legacy` alias pinned to the old revision.
+/// Dispatches on the first element of `proof_facts`:
+/// - V0 → `privacy-circuit-verify-v0` (pinned to the previous upstream revision).
+/// - V1 → `privacy-circuit-verify-v1` (current upstream revision).
 pub fn verify_proof(proof_facts: ProofFacts, proof: Proof) -> Result<(), VerifyProofError> {
     // Reject empty proof payloads before running the verifier.
     if proof.is_empty() {
         return Err(VerifyProofError::EmptyProof);
     }
 
     let proof_version_felt = proof_facts.0.first().copied().unwrap_or_default();
-    let _proof_version = ProofVersion::try_from(proof_version_felt)
+    let proof_version = ProofVersion::try_from(proof_version_felt)
         .map_err(|()| VerifyProofError::InvalidProofVersion { actual: proof_version_felt })?;
 
-    // Reconstruct the output preimage from proof facts and verify the proof.
     let output_preimage = reconstruct_output_preimage(&proof_facts)?;
     // TODO(Avi): Avoid cloning the proof.
-    let proof_output = PrivacyProofOutput { proof: proof.0.to_vec(), output_preimage };
-    verify_recursive_circuit(&proof_output)
-        .map_err(|e| VerifyProofError::Verification(e.to_string()))?;
+    let proof_bytes = proof.0.to_vec();
+
+    match proof_version {
+        ProofVersion::V0 => {
+            let proof_output = privacy_circuit_verify_v0::PrivacyProofOutput {
+                proof: proof_bytes,
+                output_preimage,
+            };
+            privacy_circuit_verify_v0::verify_recursive_circuit(&proof_output)
+                .map_err(|e| VerifyProofError::Verification(e.to_string()))?;
+        }
+        ProofVersion::V1 => {
+            let proof_output = privacy_circuit_verify_v1::PrivacyProofOutput {
+                proof: proof_bytes,
+                output_preimage,
+            };
+            privacy_circuit_verify_v1::verify_recursive_circuit(&proof_output)
+                .map_err(|e| VerifyProofError::Verification(e.to_string()))?;
+        }
+    }
 
     Ok(())
 }

crates/starknet_proof_verifier/Cargo.toml

@@ -67,7 +67,7 @@ blockifier_test_utils.workspace = true
 flate2.workspace = true
 jsonschema.workspace = true
 mockito.workspace = true
-privacy-circuit-verify.workspace = true
+privacy-circuit-verify-v1.workspace = true
 reqwest.workspace = true
 rstest.workspace = true
 serde = { workspace = true, features = ["derive"] }

crates/starknet_proof_verifier/resources/regression_test/0.14.3/example_proof.bin

@@ -3,7 +3,7 @@ use std::sync::Arc;
 
 use apollo_infra_utils::path::resolve_project_relative_path;
 use cairo_vm::vm::runners::cairo_pie::CairoPie;
-use privacy_circuit_verify::{verify_recursive_circuit, PrivacyProofOutput};
+use privacy_circuit_verify_v1::{verify_recursive_circuit, PrivacyProofOutput};
 use privacy_prove::{prepare_recursive_prover_precomputes, RecursiveProverPrecomputes};
 use starknet_api::transaction::fields::VIRTUAL_SNOS;
 use starknet_proof_verifier::ProgramOutput;