Skip to content

Commit f3763da

Browse files
deployment: drop observer_applicable label in alert_builder (#14218)
PR #13938 ("apollo_dashboard: observer applicability affects expression") moved observer applicability into the alert PromQL expression and removed the field from crates/apollo_dashboard/resources/dev_grafana_alerts.json (83 occurrences -> 0), but alert_builder.py was not updated and still references dev_alert["observer_applicable"], crashing every deployment that generates monitoring resources with KeyError: 'observer_applicable'. Drop the dead label so monitoring generation succeeds at tags APOLLO-0.14.3-RC.0 / RC.1 and on main.
1 parent dff0a9f commit f3763da

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

deployments/monitoring/src/builders/alert_builder.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,6 @@ def alert_builder(args: argparse.Namespace):
318318
datasource_uid=args.datasource_uid,
319319
labels={
320320
"og_priority": dev_alert["severity"],
321-
"observer_applicable": dev_alert["observer_applicable"],
322321
},
323322
)
324323
)

0 commit comments

Comments
 (0)