Skip to content

starknet_os_flow_tests: fuzz test orchestrator address in contract state#12956

Merged
dorimedini-starkware merged 1 commit into
main-v0.14.2from
03-01-starknet_os_flow_tests_fuzz_test_orchestrator_address_in_contract_state
Mar 3, 2026
Merged

starknet_os_flow_tests: fuzz test orchestrator address in contract state#12956
dorimedini-starkware merged 1 commit into
main-v0.14.2from
03-01-starknet_os_flow_tests_fuzz_test_orchestrator_address_in_contract_state

Conversation

@dorimedini-starkware

@dorimedini-starkware dorimedini-starkware commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Updates the fuzz-test feature contracts’ ABI/constructor behavior and regenerates compiled artifacts, which changes compiled class hashes and can break downstream tests or assumptions that depend on exact hashes/entrypoints.

Overview
Adds an orchestrator_address field to the fuzz_revert and fuzz_revert_2 feature contracts (Cairo0 and Cairo1) and introduces an initialize entrypoint that writes this value to storage.

The constructor now accepts an optional orchestrator address and, when non-zero, calls initialize to persist it; all compiled artifacts (compiled/*.json, Sierra/CASM) are regenerated accordingly. Expected compiled class hashes for FUZZ_TEST* in contracts.rs are updated to match the new contract classes.

Written by Cursor Bugbot for commit efedd19. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).


crates/blockifier_test_utils/resources/feature_contracts/cairo0/fuzz_revert.cairo line 26 at r1 (raw file):

    }
    return ();
}

Suggestion:

@constructor
func constructor{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}(
    maybe_orchestrator_address: felt,
) {
    if (maybe_orchestrator_address != 0) {
        initialize(maybe_orchestrator_address);
        return ()
    }
    return ();
}

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-01-starknet_os_flow_tests_fuzz_test_orchestrator_address_in_contract_state branch from efedd19 to 9cd6151 Compare March 2, 2026 18:36
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/12956 to 03-01-starknet_os_flow_tests_fuzz_test_initial_contracts March 2, 2026 18:36
@dorimedini-starkware dorimedini-starkware force-pushed the 03-01-starknet_os_flow_tests_fuzz_test_initial_contracts branch from fee963a to 6b0d614 Compare March 3, 2026 09:35
@dorimedini-starkware dorimedini-starkware force-pushed the 03-01-starknet_os_flow_tests_fuzz_test_orchestrator_address_in_contract_state branch from 9cd6151 to 0804e95 Compare March 3, 2026 09:35

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 03-01-starknet_os_flow_tests_fuzz_test_initial_contracts to main-v0.14.2 March 3, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 03-01-starknet_os_flow_tests_fuzz_test_orchestrator_address_in_contract_state branch from 0804e95 to 39d07ec Compare March 3, 2026 10:25
@graphite-app

graphite-app Bot commented Mar 3, 2026

Copy link
Copy Markdown

Merge activity

  • Mar 3, 10:25 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main-v0.14.2 with commit 9bb63e4 Mar 3, 2026
27 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants