starknet_os: refactor build commitment infos

[AvivYossef-starkware]

Note

Medium Risk
Touches core state commitment/proof construction logic by changing how per-contract storage roots are fetched and how the API is invoked, which could affect root/proof correctness if the refactor diverges from prior behavior.

Overview
Refactors commitment-info construction by replacing the free function create_commitment_infos with StateCommitmentInfos::new, and simplifying the internal flow to fetch previous and new per-contract storage roots via a single get_storage_roots helper.

Updates downstream callers (flow tests and transaction prover) to use the new constructor API, and switches to committer helpers for contract-address↔node-index conversion while tightening error mapping.

^{Reviewed by Cursor Bugbot for commit 155be8c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_os: refactor build commitment infos #13039 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware reviewed 3 files and made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on AvivYossef-starkware and Yoni-Starkware).

---

crates/starknet_os/src/commitment_infos.rs line 151 at r1 (raw file):

/// Fetches the storage root hash of each contract from the contracts trie at the given root.
async fn get_storage_roots(
    contract_addresses: &[ContractAddress],

Consider changing it to avoid collecting to a vec from outside. non-blocking

Suggestion:

contract_addresses: &impl Iterator<Item=&ContractAddress>

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[AvivYossef-starkware]

Re Nimrod's suggestion to change contract_addresses: &[ContractAddress] to an iterator — since get_storage_roots is called twice (once for previous roots and once for new roots), accepting an iterator would either require cloning the iterator or adding a lifetime, making the signature more complex for no real gain. Keeping &[ContractAddress] is simpler here.

[github-actions]

Artifacts upload workflows:

• Started at 2026-04-06T07:50:17Z

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on nimrod-starkware and Yoni-Starkware).

---

crates/starknet_os/src/commitment_infos.rs line 151 at r1 (raw file):

Previously, nimrod-starkware wrote…

Consider changing it to avoid collecting to a vec from outside. non-blocking

Re Nimrod's suggestion to change contract_addresses: &[ContractAddress] to an iterator — since get_storage_roots is called twice (once for previous roots and once for new roots), accepting an iterator would either require cloning the iterator or adding a lifetime, making the signature more complex for no real gain. Keeping &[ContractAddress] is simpler here.

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 4 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).