Skip to content

starknet_os_flow_tests: expect initial fuzz test addresses#13042

Merged
dorimedini-starkware merged 1 commit into
main-v0.14.2from
03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses
Mar 10, 2026
Merged

starknet_os_flow_tests: expect initial fuzz test addresses#13042
dorimedini-starkware merged 1 commit into
main-v0.14.2from
03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 5, 2026

Note

Low Risk
Test-only change that hard-codes and asserts deterministic contract addresses; main risk is making fuzz tests brittle if deployment ordering/address derivation changes.

Overview
Adds expect_test-backed golden values for the initial fuzz test contract addresses (orchestrator + 4 fuzz contracts) and uses them as stable LazyLock<ContractAddress> constants.

Refactors fuzz test setup to centralize deployment in init_deployment(assert_expect) (optionally asserting the deployed addresses), removes orchestrator_contract_address from the fuzz context, and updates deploy-address derivation and orchestrator calls to reference the fixed orchestrator address. Adds a new test_fuzz_deployment_expect to validate/update the expected addresses.

Written by Cursor Bugbot for commit 22c9dc3. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented Mar 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses branch from d97aec5 to e2d66ec Compare March 9, 2026 14:49
@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_split_fuzz_test_manager_from_context branch from 5c88961 to 58008ca Compare March 9, 2026 14:49
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@graphite-app graphite-app Bot changed the base branch from 03-03-starknet_os_flow_tests_split_fuzz_test_manager_from_context to graphite-base/13042 March 9, 2026 19:01
@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses branch from e2d66ec to 22c9dc3 Compare March 10, 2026 10:59
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/13042 to main-v0.14.2 March 10, 2026 10:59
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants