Skip to content

starknet_os_flow_tests: move deployed fuzz test map to be static#13043

Merged
dorimedini-starkware merged 1 commit into
main-v0.14.2from
03-03-starknet_os_flow_tests_move_deployed_fuzz_test_map_to_be_static
Mar 10, 2026
Merged

starknet_os_flow_tests: move deployed fuzz test map to be static#13043
dorimedini-starkware merged 1 commit into
main-v0.14.2from
03-03-starknet_os_flow_tests_move_deployed_fuzz_test_map_to_be_static

Conversation

@dorimedini-starkware

@dorimedini-starkware dorimedini-starkware commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Test-only refactor that mainly reorganizes state tracking and lookup logic; risk is limited to subtle regressions in fuzz flow test bookkeeping (deploy/replace/revert).

Overview
Moves the initial fuzz-contract address -> class hash mapping into a static FUZZ_ADDRESS_TO_CLASS_HASH, and updates initialization and call-operation generation to iterate over this shared map plus any newly_deployed_contracts.

Refactors replace-class handling to track the replaced address (replaced_address) and resolve class hashes dynamically via try_class_hash_of/class_hash_of, and adjusts revert bookkeeping so class replacement reverts correctly alongside deploy reverts.

Written by Cursor Bugbot for commit aee687b. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_move_deployed_fuzz_test_map_to_be_static branch from f5edab0 to ebbcac9 Compare March 6, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses branch from 787adf3 to d97aec5 Compare March 6, 2026 11:56

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread crates/starknet_os_flow_tests/src/fuzz_tests.rs

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on Yoni-Starkware).

Comment thread crates/starknet_os_flow_tests/src/fuzz_tests.rs

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses branch from d97aec5 to e2d66ec Compare March 9, 2026 14:49
@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_move_deployed_fuzz_test_map_to_be_static branch from ebbcac9 to 5f699a5 Compare March 9, 2026 14:49

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_move_deployed_fuzz_test_map_to_be_static branch from 5f699a5 to c70f63f Compare March 10, 2026 10:59
@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses branch from e2d66ec to 22c9dc3 Compare March 10, 2026 10:59

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 03-03-starknet_os_flow_tests_expect_initial_fuzz_test_addresses to main-v0.14.2 March 10, 2026 14:13
@dorimedini-starkware dorimedini-starkware force-pushed the 03-03-starknet_os_flow_tests_move_deployed_fuzz_test_map_to_be_static branch from c70f63f to aee687b Compare March 10, 2026 14:14
@graphite-app

graphite-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

Merge activity

  • Mar 10, 2:14 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants