starknet_os_flow_tests: make fuzz test Cairo1 scenarios an enum#13153
Merged
dorimedini-starkware merged 1 commit intoApr 5, 2026
Conversation
This was referenced Mar 10, 2026
This was referenced Mar 10, 2026
Yoni-Starkware
approved these changes
Mar 10, 2026
Collaborator
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
Collaborator
Author
This was referenced Mar 11, 2026
0b51682 to
989ba5f
Compare
f5a603b to
9db6e63
Compare
88a0573 to
133ea1e
Compare
9db6e63 to
36ce413
Compare
133ea1e to
f11c982
Compare
36ce413 to
e158327
Compare
e158327 to
bb9a379
Compare
f11c982 to
b8fc30a
Compare
Yoni-Starkware
approved these changes
Mar 30, 2026
Collaborator
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
bb9a379 to
a8d3ad0
Compare
1f2e886 to
d377b30
Compare
a8d3ad0 to
60d66e9
Compare
60d66e9 to
fb35a9d
Compare
Merge activity
|
Collaborator
Author
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk: changes are limited to fuzz-test Cairo1 contracts and expected test addresses, with no production runtime impact. Main risk is potential mismatch between orchestrator-provided scenario IDs and the new enum mapping causing test failures.
Overview
Refactors the Cairo1 fuzz revert contracts (
fuzz_revert.cairoand the auto-generatedfuzz_revert_2.cairo) to replace numericSCENARIO_*constants with a typedScenarioenum and afelt252 -> Scenarioconversion, switching the dispatcher to a singlematch.Adds an explicit failure path for unknown scenario identifiers: the orchestrator now exposes
should_fail_invalid_scenario_panic_message, and the fuzz contracts panic with this value when an invalid ID is encountered; the orchestrator also treats this as an unexpected error duringstart_test.Updates
starknet_os_flow_testsexpected deployed fuzz contract addresses to match the new class hashes produced by the Cairo1 contract changes.Reviewed by Cursor Bugbot for commit fb35a9d. Bugbot is set up for automated code reviews on this repo. Configure here.