Skip to content

starknet_os_flow_tests: fuzz test emit event scenario#13154

Merged
dorimedini-starkware merged 1 commit into
mainfrom
03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario
Apr 5, 2026
Merged

starknet_os_flow_tests: fuzz test emit event scenario#13154
dorimedini-starkware merged 1 commit into
mainfrom
03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 10, 2026

Note

Low Risk
Low risk: changes are confined to test contracts and flow-test harness, adding event emission coverage and expected-event assertions without altering production execution logic.

Overview
Adds a new fuzzing operation/scenario to emit Starknet events during the revert-fuzz flow (Cairo0 and Cairo1), including corresponding FuzzEvent definitions and an EmitEvent branch in the scenario dispatcher.

Updates the OS flow fuzz test harness to generate event operations, track emitted event payloads per call frame, and assert expected events by passing per-tx EventPredicateExpectations into TestBuilder::add_invoke_tx. Regenerates the Cairo0 compiled artifact (fuzz_revert_compiled.json) to include the new event ABI/syscall.

Reviewed by Cursor Bugbot for commit 2492929. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 0ad7c10 to 1a35509 Compare March 11, 2026 09:08
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch from 750f3f7 to c5906e9 Compare March 11, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 1a35509 to 1d9e737 Compare March 11, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch from c5906e9 to f5a603b Compare March 11, 2026 14:12
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 1d9e737 to d4f0ad4 Compare March 11, 2026 14:12
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread crates/starknet_os_flow_tests/src/fuzz_tests.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from d4f0ad4 to ff032c0 Compare March 11, 2026 16:19
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch 2 times, most recently from 9db6e63 to 36ce413 Compare March 15, 2026 14:30
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from ff032c0 to 9941f34 Compare March 15, 2026 14:30
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch from 36ce413 to e158327 Compare March 16, 2026 13:01
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 9941f34 to 3f3bd7c Compare March 16, 2026 13:01
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch from e158327 to bb9a379 Compare March 24, 2026 15:57
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 3f3bd7c to 04c43c5 Compare March 24, 2026 15:57
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: 6 of 10 files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch from bb9a379 to a8d3ad0 Compare March 31, 2026 07:16
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 04c43c5 to 8a163d3 Compare March 31, 2026 07:16
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum branch from a8d3ad0 to 60d66e9 Compare March 31, 2026 08:57
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 8a163d3 to 5f143fe Compare March 31, 2026 08:57
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 10 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@graphite-app graphite-app Bot changed the base branch from 03-09-starknet_os_flow_tests_make_fuzz_test_cairo1_scenarios_an_enum to graphite-base/13154 April 5, 2026 07:12
@dorimedini-starkware dorimedini-starkware force-pushed the 03-09-starknet_os_flow_tests_fuzz_test_emit_event_scenario branch from 5f143fe to 2492929 Compare April 5, 2026 08:13
@graphite-app graphite-app Bot changed the base branch from graphite-base/13154 to main April 5, 2026 08:13
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 5, 2026

Merge activity

  • Apr 5, 8:13 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Apr 5, 2026
Merged via the queue into main with commit 2e7ba5f Apr 5, 2026
34 of 91 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants