apollo_infra: add request max size tests#13559
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
63e5ff3 to
1ff7987
Compare
1ff7987 to
ab520df
Compare
ab520df to
c1e5146
Compare
|
Artifacts upload workflows: |
c1e5146 to
f071271
Compare
f071271 to
fbb1c23
Compare
PR SummaryMedium Risk Overview Introduces Reviewed by Cursor Bugbot for commit fbb1c23. Bugbot is set up for automated code reviews on this repo. Configure here. |
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).

Note
Medium Risk
Changes the serialized
ServerErrorreturned for oversized requests, which can break clients/tests that pattern-match on the previousRequestDeserializationFailurevariant. Otherwise the change is localized (HTTP size limit path + new tests) and low complexity.Overview
Remote server now returns a distinct
ServerError::RequestBodyTooLargewhen an incoming HTTP request exceedsmax_request_body_bytes, logging it atwarnand responding with413 Payload Too Large.Adds
max_request_size_testto validate the 413/RequestBodyTooLargebehavior and that the remote client surfacesClientError::ResponseParsingFailurewhen a response exceedsmax_response_body_bytes; also centralizesFAST_FAILING_CLIENT_CONFIGintotests::test_utilsfor reuse.Reviewed by Cursor Bugbot for commit f071271. Bugbot is set up for automated code reviews on this repo. Configure here.