Skip to content

ci,scripts: install LLVM before cargo tools#13674

Merged
avi-starkware merged 1 commit into
avi/compiler-verify-fnfrom
avi/compiler-bootstrap-order
May 17, 2026
Merged

ci,scripts: install LLVM before cargo tools#13674
avi-starkware merged 1 commit into
avi/compiler-verify-fnfrom
avi/compiler-bootstrap-order

Conversation

@avi-starkware

@avi-starkware avi-starkware commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Reorder bootstrap and install_build_tools.sh so LLVM 19 is installed
before cargo tools. This is needed because install_cargo_tools.sh will
install starknet-native-compile which requires LLVM to build.

Safe change: LLVM installation does not depend on Rust.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com


Note

Medium Risk
Touches CI/build installation order; low code risk but can break developer/CI environments if the new sequencing has untested assumptions or OS-specific differences.

Overview
Reorders CI/bootstrap and local build tooling installation so scripts/dependencies.sh (LLVM 19 + related native deps) runs before install_cargo_tools.sh, ensuring cargo-installed tools that compile native code (e.g., starknet-native-compile) have LLVM available.

In the bootstrap composite action, setup_native_deps is now executed before installing Rust to match the updated dependency ordering.

Reviewed by Cursor Bugbot for commit 1efda68. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 8f5f979 to 7de22cb Compare April 6, 2026 13:55
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 92e7bf5 to 9c686ef Compare April 6, 2026 13:55
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 7de22cb to 3a48b7d Compare April 6, 2026 16:27
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 9c686ef to ac92fec Compare April 6, 2026 16:27
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 3a48b7d to 5340959 Compare April 6, 2026 17:10
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from ac92fec to 36d086b Compare April 6, 2026 17:10
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 5340959 to c99c411 Compare April 6, 2026 20:26
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 36d086b to e332679 Compare April 6, 2026 20:26
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from c99c411 to 255af4f Compare April 7, 2026 05:34
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from e332679 to 7cc069b Compare April 7, 2026 05:35
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 255af4f to fc149a5 Compare April 7, 2026 06:35
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 7cc069b to 1efda68 Compare April 7, 2026 06:35
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 7, 2026
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from fc149a5 to fce8efa Compare May 10, 2026 07:40
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 1efda68 to 4af9d22 Compare May 10, 2026 07:40
@cursor

cursor Bot commented May 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk ordering change in CI/scripts, but could affect build setup if dependencies.sh or native deps have hidden assumptions about Rust/toolchain state.

Overview
Updates the bootstrap composite action to install native Cairo/LLVM dependencies before installing Rust.

Adjusts scripts/install_build_tools.sh to run dependencies.sh (with clearer logging) prior to install_cargo_tools.sh, ensuring cargo-installed tools that compile native code have required system dependencies available.

Reviewed by Cursor Bugbot for commit cf03fe4. Bugbot is set up for automated code reviews on this repo. Configure here.

@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from fce8efa to 325c4a1 Compare May 10, 2026 11:21
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 4af9d22 to 7e79823 Compare May 10, 2026 11:21
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 325c4a1 to 20549f4 Compare May 14, 2026 11:37
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch 2 times, most recently from 5b12ec8 to eb8a28f Compare May 14, 2026 11:50
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 20549f4 to d54f3d7 Compare May 14, 2026 11:50

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from d54f3d7 to 8447b4b Compare May 17, 2026 09:00
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch 2 times, most recently from b9df359 to a3838df Compare May 17, 2026 11:02
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch 2 times, most recently from 0199504 to 8ee60b3 Compare May 17, 2026 11:32
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from a3838df to 0f949ae Compare May 17, 2026 11:32
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 8ee60b3 to c71a98e Compare May 17, 2026 11:40
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from 0f949ae to 3310da5 Compare May 17, 2026 11:40
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from c71a98e to c7f2d76 Compare May 17, 2026 12:26
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch 2 times, most recently from 4a93319 to d026aa4 Compare May 17, 2026 14:07
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from c7f2d76 to 13cb3a0 Compare May 17, 2026 14:07
Reorder bootstrap and install_build_tools.sh so LLVM 19 is installed
before cargo tools. This is needed because install_cargo_tools.sh will
install starknet-native-compile which requires LLVM to build.

Safe change: LLVM installation does not depend on Rust.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@avi-starkware avi-starkware force-pushed the avi/compiler-bootstrap-order branch from d026aa4 to cf03fe4 Compare May 17, 2026 14:56
@avi-starkware avi-starkware force-pushed the avi/compiler-verify-fn branch from 13cb3a0 to 2efa7c6 Compare May 17, 2026 14:56
@avi-starkware avi-starkware merged commit 08764c4 into avi/compiler-verify-fn May 17, 2026
31 of 59 checks passed
@avi-starkware avi-starkware deleted the avi/compiler-bootstrap-order branch May 17, 2026 21:01
@avi-starkware avi-starkware restored the avi/compiler-bootstrap-order branch May 17, 2026 21:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants