ci,scripts: install LLVM before cargo tools#13674
Conversation
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).
8f5f979 to
7de22cb
Compare
92e7bf5 to
9c686ef
Compare
7de22cb to
3a48b7d
Compare
9c686ef to
ac92fec
Compare
3a48b7d to
5340959
Compare
ac92fec to
36d086b
Compare
5340959 to
c99c411
Compare
36d086b to
e332679
Compare
c99c411 to
255af4f
Compare
e332679 to
7cc069b
Compare
255af4f to
fc149a5
Compare
7cc069b to
1efda68
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
fc149a5 to
fce8efa
Compare
1efda68 to
4af9d22
Compare
PR SummaryLow Risk Overview Adjusts Reviewed by Cursor Bugbot for commit cf03fe4. Bugbot is set up for automated code reviews on this repo. Configure here. |
fce8efa to
325c4a1
Compare
4af9d22 to
7e79823
Compare
325c4a1 to
20549f4
Compare
5b12ec8 to
eb8a28f
Compare
20549f4 to
d54f3d7
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).
d54f3d7 to
8447b4b
Compare
b9df359 to
a3838df
Compare
0199504 to
8ee60b3
Compare
a3838df to
0f949ae
Compare
8ee60b3 to
c71a98e
Compare
0f949ae to
3310da5
Compare
c71a98e to
c7f2d76
Compare
4a93319 to
d026aa4
Compare
c7f2d76 to
13cb3a0
Compare
Reorder bootstrap and install_build_tools.sh so LLVM 19 is installed before cargo tools. This is needed because install_cargo_tools.sh will install starknet-native-compile which requires LLVM to build. Safe change: LLVM installation does not depend on Rust. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d026aa4 to
cf03fe4
Compare
13cb3a0 to
2efa7c6
Compare

Reorder bootstrap and install_build_tools.sh so LLVM 19 is installed
before cargo tools. This is needed because install_cargo_tools.sh will
install starknet-native-compile which requires LLVM to build.
Safe change: LLVM installation does not depend on Rust.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Note
Medium Risk
Touches CI/build installation order; low code risk but can break developer/CI environments if the new sequencing has untested assumptions or OS-specific differences.
Overview
Reorders CI/bootstrap and local build tooling installation so
scripts/dependencies.sh(LLVM 19 + related native deps) runs beforeinstall_cargo_tools.sh, ensuring cargo-installed tools that compile native code (e.g.,starknet-native-compile) have LLVM available.In the
bootstrapcomposite action,setup_native_depsis now executed before installing Rust to match the updated dependency ordering.Reviewed by Cursor Bugbot for commit 1efda68. Bugbot is set up for automated code reviews on this repo. Configure here.