Skip to content

apollo_compilation_utils: remove dead install_compiler_binary and legacy paths#13676

Merged
avi-starkware merged 1 commit into
mainfrom
avi/compiler-install-cleanup
May 19, 2026
Merged

apollo_compilation_utils: remove dead install_compiler_binary and legacy paths#13676
avi-starkware merged 1 commit into
mainfrom
avi/compiler-install-cleanup

Conversation

@avi-starkware

@avi-starkware avi-starkware commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Remove code that is no longer used after the switch to script-based
compiler installation:

  • Remove install_compiler_binary() and legacy_binary_path()
  • Remove shared_folder_dir(), target_dir() from paths.rs
  • Remove tempfile build-dependency from apollo_compilation_utils
  • Update workflow artifact path and BUILD file

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com


Note

Low Risk
Removes dead build/installation code and unused path helpers; runtime behavior should be unchanged aside from no longer supporting the legacy shared-executables location.

Overview
Removes the unused build-time install_compiler_binary flow and its related legacy path helpers (legacy_binary_path, shared_folder_dir, target_dir), leaving compiler binaries to be resolved via PATH and validated only through verify_compiler_binary.

Cleans up apollo_compilation_utils crate configuration by dropping the now-unneeded [build-dependencies] entries tied to the old installation mechanism.

Reviewed by Cursor Bugbot for commit 62a7a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

@avi-starkware avi-starkware marked this pull request as ready for review April 6, 2026 10:46

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on avi-starkware).


.github/workflows/upload_artifacts_workflow.yml line 148 at r1 (raw file):

      - name: Copy starknet-native-compile for upload
        run: cp "$HOME/.cargo/bin/starknet-native-compile" target/release/starknet-native-compile

doesn't this belong in the previous PR...? without it you don't get uploaded native binary, right?

Code quote:

      - name: Copy starknet-native-compile for upload
        run: cp "$HOME/.cargo/bin/starknet-native-compile" target/release/starknet-native-compile

.github/workflows/upload_artifacts_workflow.yml line 155 at r1 (raw file):

        with:
          path: "target/release/starknet-native-compile"
          destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"

why copy and not just take the new source path?

Suggestion:

      - name: Upload starknet-native-compile to GCP
        id: upload_snc_file
        uses: "google-github-actions/upload-cloud-storage@v2"
        with:
          path: "$HOME/.cargo/bin/starknet-native-compile"
          destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"

@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from dff8e6e to cb2af9b Compare April 6, 2026 13:55
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch 2 times, most recently from 5814201 to 0f636e6 Compare April 6, 2026 16:27
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from cb2af9b to 42fdf4b Compare April 6, 2026 16:27
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 0f636e6 to 1c8c980 Compare April 6, 2026 17:10
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 42fdf4b to ffeb93e Compare April 6, 2026 17:10
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 1c8c980 to 6b06cdf Compare April 6, 2026 20:26
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from ffeb93e to 7467499 Compare April 6, 2026 20:26
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 6b06cdf to a529b9e Compare April 7, 2026 05:35
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 7467499 to fe2bc47 Compare April 7, 2026 05:35
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from a529b9e to c698fc8 Compare April 7, 2026 06:35
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from fe2bc47 to 62a7a3d Compare April 7, 2026 06:35

@avi-starkware avi-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware made 2 comments.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).


.github/workflows/upload_artifacts_workflow.yml line 148 at r1 (raw file):

Previously, dorimedini-starkware wrote…

doesn't this belong in the previous PR...? without it you don't get uploaded native binary, right?

Done.


.github/workflows/upload_artifacts_workflow.yml line 155 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why copy and not just take the new source path?

Done.

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 8, 2026
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from c698fc8 to fd0d72f Compare May 10, 2026 07:40
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 62a7a3d to bfbfc21 Compare May 10, 2026 07:41
@cursor

cursor Bot commented May 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk cleanup that removes unused build-time installation/legacy path code; main impact is if any downstream build scripts still depended on these removed helpers.

Overview
Removes the dead install_compiler_binary build-time installer and associated legacy path helpers (shared_folder_dir, target_dir, legacy_binary_path), leaving apollo_compilation_utils focused on runtime verification via verify_compiler_binary and deterministic binary_path resolution.

Cleans up Cargo.toml by dropping the crate’s build-dependencies section that supported the removed installer.

Reviewed by Cursor Bugbot for commit efcf7b8. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 71330cb to baadf84 Compare May 17, 2026 11:32
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 88fbcdf to 1ed25b9 Compare May 17, 2026 11:32
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from baadf84 to b7be36d Compare May 17, 2026 11:40
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch 2 times, most recently from 997e418 to dcab7e0 Compare May 17, 2026 12:26
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch 2 times, most recently from 9d70e62 to e5281e4 Compare May 17, 2026 14:07
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch 2 times, most recently from e47d311 to dbefd7c Compare May 17, 2026 14:56
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from e5281e4 to a9c31f9 Compare May 17, 2026 14:56
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from dbefd7c to 9d06d17 Compare May 17, 2026 15:19
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from a9c31f9 to 535bdb8 Compare May 17, 2026 15:19
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 9d06d17 to 552eb81 Compare May 17, 2026 15:24
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 535bdb8 to 3be19c8 Compare May 17, 2026 15:24
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 552eb81 to 7b933c8 Compare May 17, 2026 15:34
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 3be19c8 to 172169b Compare May 17, 2026 15:34
@github-actions github-actions Bot removed the stale label May 18, 2026
@avi-starkware avi-starkware force-pushed the avi/compiler-install-switch branch from 7b933c8 to db6e93d Compare May 18, 2026 14:31
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from 172169b to b978f24 Compare May 18, 2026 14:31
…acy paths

Remove code that is no longer used after the switch to script-based
compiler installation:

- Remove install_compiler_binary() and legacy_binary_path()
- Remove shared_folder_dir(), target_dir() from paths.rs
- Remove tempfile build-dependency from apollo_compilation_utils
- Update workflow artifact path and BUILD file

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@avi-starkware avi-starkware changed the base branch from avi/compiler-install-switch to graphite-base/13676 May 19, 2026 06:25
@avi-starkware avi-starkware force-pushed the graphite-base/13676 branch from db6e93d to 3f0deb2 Compare May 19, 2026 06:25
@avi-starkware avi-starkware force-pushed the avi/compiler-install-cleanup branch from b978f24 to efcf7b8 Compare May 19, 2026 06:25
@avi-starkware avi-starkware changed the base branch from graphite-base/13676 to main May 19, 2026 06:25
@avi-starkware avi-starkware added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit da04d3e May 19, 2026
18 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants