apollo_compilation_utils: remove dead install_compiler_binary and legacy paths#13676
Conversation
|
Artifacts upload workflows: |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on avi-starkware).
.github/workflows/upload_artifacts_workflow.yml line 148 at r1 (raw file):
- name: Copy starknet-native-compile for upload run: cp "$HOME/.cargo/bin/starknet-native-compile" target/release/starknet-native-compile
doesn't this belong in the previous PR...? without it you don't get uploaded native binary, right?
Code quote:
- name: Copy starknet-native-compile for upload
run: cp "$HOME/.cargo/bin/starknet-native-compile" target/release/starknet-native-compile.github/workflows/upload_artifacts_workflow.yml line 155 at r1 (raw file):
with: path: "target/release/starknet-native-compile" destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"
why copy and not just take the new source path?
Suggestion:
- name: Upload starknet-native-compile to GCP
id: upload_snc_file
uses: "google-github-actions/upload-cloud-storage@v2"
with:
path: "$HOME/.cargo/bin/starknet-native-compile"
destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"dff8e6e to
cb2af9b
Compare
5814201 to
0f636e6
Compare
cb2af9b to
42fdf4b
Compare
0f636e6 to
1c8c980
Compare
42fdf4b to
ffeb93e
Compare
1c8c980 to
6b06cdf
Compare
ffeb93e to
7467499
Compare
6b06cdf to
a529b9e
Compare
7467499 to
fe2bc47
Compare
a529b9e to
c698fc8
Compare
fe2bc47 to
62a7a3d
Compare
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware made 2 comments.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).
.github/workflows/upload_artifacts_workflow.yml line 148 at r1 (raw file):
Previously, dorimedini-starkware wrote…
doesn't this belong in the previous PR...? without it you don't get uploaded native binary, right?
Done.
.github/workflows/upload_artifacts_workflow.yml line 155 at r1 (raw file):
Previously, dorimedini-starkware wrote…
why copy and not just take the new source path?
Done.
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 3 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
c698fc8 to
fd0d72f
Compare
62a7a3d to
bfbfc21
Compare
PR SummaryLow Risk Overview Cleans up Reviewed by Cursor Bugbot for commit efcf7b8. Bugbot is set up for automated code reviews on this repo. Configure here. |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).
71330cb to
baadf84
Compare
88fbcdf to
1ed25b9
Compare
baadf84 to
b7be36d
Compare
997e418 to
dcab7e0
Compare
9d70e62 to
e5281e4
Compare
e47d311 to
dbefd7c
Compare
e5281e4 to
a9c31f9
Compare
dbefd7c to
9d06d17
Compare
a9c31f9 to
535bdb8
Compare
9d06d17 to
552eb81
Compare
535bdb8 to
3be19c8
Compare
552eb81 to
7b933c8
Compare
3be19c8 to
172169b
Compare
7b933c8 to
db6e93d
Compare
172169b to
b978f24
Compare
…acy paths Remove code that is no longer used after the switch to script-based compiler installation: - Remove install_compiler_binary() and legacy_binary_path() - Remove shared_folder_dir(), target_dir() from paths.rs - Remove tempfile build-dependency from apollo_compilation_utils - Update workflow artifact path and BUILD file Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
db6e93d to
3f0deb2
Compare
b978f24 to
efcf7b8
Compare

Remove code that is no longer used after the switch to script-based
compiler installation:
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Note
Low Risk
Removes dead build/installation code and unused path helpers; runtime behavior should be unchanged aside from no longer supporting the legacy shared-executables location.
Overview
Removes the unused build-time
install_compiler_binaryflow and its related legacy path helpers (legacy_binary_path,shared_folder_dir,target_dir), leaving compiler binaries to be resolved viaPATHand validated only throughverify_compiler_binary.Cleans up
apollo_compilation_utilscrate configuration by dropping the now-unneeded[build-dependencies]entries tied to the old installation mechanism.Reviewed by Cursor Bugbot for commit 62a7a3d. Bugbot is set up for automated code reviews on this repo. Configure here.