apollo_l1_gas_price,apollo_l1_gas_price_config: move exchange_rate_decimals const to config

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_consensus_orchestrator: add SNIP-35 integration TODO doc #13982
• apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE) #13857
• apollo_l1_gas_price,apollo_l1_gas_price_config: move exchange_rate_decimals const to config #13881 👈 (View in Graphite)
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856 : 2 other dependent PRs (#14216 , #14220 )
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider #14161
• apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays #14160
• apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate #14159
• apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate #14158
• apollo_l1_gas_price: parameterize ExchangeRateOracleClient by metric set #14199
• apollo_l1_gas_price_config,apollo_node: add strk_to_usd_oracle_config #14157
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 1 other dependent PR (#13820 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Behavior is unchanged at the default of 18; only misconfiguration or a mismatched oracle feed would alter L1 gas price conversion validation.

Overview
Makes the expected oracle decimals field configurable instead of a hard-coded constant, so ETH→STRK and STRK→USD oracles can each declare their own precision.

ExchangeRateOracleConfig gains exchange_rate_decimals (default 18, documented for ETH/STRK), with serialization in config_schema.json. ExchangeRateOracleClient drops EXCHANGE_RATE_DECIMALS and rejects API responses whose decimals do not match the configured value. Integration tests stop depending on apollo_l1_gas_price for that constant and return decimals: 18 from the fake oracle.

^{Reviewed by Cursor Bugbot for commit adab40d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[ShahakShama]

@ShahakShama reviewed 4 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on ob1337 and sirandreww-starkware).

---

a discussion (no related file):
I'll make sure with @ob1337 that this is indeed needed

---

crates/apollo_integration_tests/src/utils.rs line 573 at r1 (raw file):

    // tests.
    let price = format!("0x{DEFAULT_ETH_TO_FRI_RATE:x}");
    let response = json!({ "timestamp": query.timestamp ,"price": price, "decimals": 18 });

If the decimals are already part of the response, why do we need them as config?

---

crates/apollo_l1_gas_price_config/src/config.rs line 31 at r1 (raw file):

    pub max_cache_size: usize,
    pub query_timeout_sec: u64,
    pub exchange_rate_decimals: u64,

I prefer this won't be a config and will instead be a separate parameter in the ctor. Then, when you initialize eth to strk you'll use 10^18 constant and when you use strk to usd you'll use a different constant

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 04875da. Configure here.}

[matanl-starkware]

@matanl-starkware reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on ob1337, ShahakShama, and sirandreww-starkware).

---

crates/apollo_integration_tests/src/utils.rs line 573 at r1 (raw file):

Previously, ShahakShama wrote…

If the decimals are already part of the response, why do we need them as config?

+1

---

crates/apollo_l1_gas_price_config/src/config.rs line 31 at r1 (raw file):

Previously, ShahakShama wrote…

I prefer this won't be a config and will instead be a separate parameter in the ctor. Then, when you initialize eth to strk you'll use 10^18 constant and when you use strk to usd you'll use a different constant

Why do we need it as a parameter of the struct at all?
Take whatever value the response contains and use it for conversion.