Skip to content

central_systest_blobs: sort hashsets when dumping#13968

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_sort_hashsets_when_dumping
May 9, 2026
Merged

central_systest_blobs: sort hashsets when dumping#13968
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_sort_hashsets_when_dumping

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Changes how blob/preconfirmed-block JSON fixtures are serialized (sorting specific set-backed arrays and updating generation), which can invalidate golden files and alter uploaded GCS blob contents. Logic is test/fixture-oriented but touches persistence format for regression artifacts.

Overview
Makes central_systest_blobs JSON outputs deterministic by normalizing serde_json::Value before pretty-printing: it recursively sorts array fields backed by HashSet iteration (e.g. accessed_blocks, accessed_contract_addresses, accessed_storage_keys). This normalized serialization is now used for the preconfirmed block expect-file and for the GCS-uploaded blobs.json.

Updates test resources accordingly (preconfirmed block JSON ordering/fields and bumps resources/blob_file_generation), and adds serde as a dev-dependency to support the new to_normalized_json helper.

Reviewed by Cursor Bugbot for commit a1675fb. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from c0d0ac9 to 0e56d10 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from f9cb358 to 24bca91 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 24bca91 to caa4531 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from 0e56d10 to 99fd2d7 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from caa4531 to 54e47dc Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch 2 times, most recently from 35f0f1b to 9c6fcc0 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 54e47dc to 1b7ea13 Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from 9c6fcc0 to c7be52a Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 1b7ea13 to 1862894 Compare May 8, 2026 13:49
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_implement_blob_creation_from_blocks to graphite-base/13968 May 8, 2026 14:21
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 1862894 to a1675fb Compare May 8, 2026 14:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Artifacts upload workflows:

@graphite-app graphite-app Bot changed the base branch from graphite-base/13968 to main May 8, 2026 14:40
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 8, 2026

Merge activity

  • May 8, 2:40 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 8d5d40f May 9, 2026
66 of 132 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants