Skip to content

central_systest_blobs: deploy operator account#13970

Merged
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_deploy_operator_account
May 9, 2026
Merged

central_systest_blobs: deploy operator account#13970
dorimedini-starkware merged 1 commit into
mainfrom
04-30-central_systest_blobs_deploy_operator_account

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Updates blob regression test data generation to include a signed DEPLOY_ACCOUNT transaction, changing the preconfirmed block fixture and transaction hashes; failures will surface as blob/fixture mismatches in CI and downstream systests.

Overview
Adds support in central_systest_blobs to generate a signed, zero-fee DEPLOY_ACCOUNT v3 transaction (including contract address calculation) and include it in the remaining-txs preconfirmed block.

Updates regression fixtures accordingly: bumps the blobs generation id and rewrites preconfirmed_block.json (block number/timestamp, receipt fee/resources, deployed contract + nonce/storage diffs, tx type/hash/signature). Also adds dev-dependencies (starknet-core, starknet-crypto, starknet-types-core) to support signing and felt key handling.

Reviewed by Cursor Bugbot for commit fd340a8. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 135396f to aa45046 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 76ca51a to 8a32ce9 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from aa45046 to 34b1097 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 8a32ce9 to 4a1e9a3 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch 2 times, most recently from 19531c8 to aa0ee34 Compare May 5, 2026 14:17
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from aa0ee34 to d469606 Compare May 8, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 16b1ded to bba23fa Compare May 8, 2026 13:49
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_initial_block_production to graphite-base/13970 May 9, 2026 08:30
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from d469606 to fd340a8 Compare May 9, 2026 12:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Artifacts upload workflows:

@graphite-app graphite-app Bot changed the base branch from graphite-base/13970 to main May 9, 2026 12:45
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2026

Merge activity

  • May 9, 12:45 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit f569e95 May 9, 2026
52 of 111 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants