Skip to content

apollo_deployment: add missing replacer configs#14005

Open
ShahakShama wants to merge 1 commit into
mainfrom
shahak/fix_missing_replacer_configs
Open

apollo_deployment: add missing replacer configs#14005
ShahakShama wants to merge 1 commit into
mainfrom
shahak/fix_missing_replacer_configs

Conversation

@ShahakShama
Copy link
Copy Markdown
Collaborator

No description provided.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Medium Risk
Changes which batcher/gateway config fields are treated as infra-supplied replacer values, which can alter runtime behavior if placeholders are misconfigured or unset.

Overview
Adds missing replacer placeholders so additional app config fields can be overridden at deploy time.

Specifically, replacer_batcher_config.json now templates batcher_config.dynamic_config.tx_polling_interval_millis and ...cairo_native_mode, and replacer_gateway_config.json now templates ...cairo_native_mode and stateless_tx_validator_config.allow_client_side_proving. The service-level KEYS_TO_BE_REPLACED set is updated to include these new keys so the replacer annotation logic will pick them up.

Reviewed by Cursor Bugbot for commit 3711ecb. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_deployments/src/service.rs line 84 at r1 (raw file):

    "gateway_config.static_config.authorized_declarer_accounts.#is_none",
    "gateway_config.static_config.authorized_declarer_accounts",
    "gateway_config.static_config.contract_class_manager_config.cairo_native_run_config.cairo_native_mode",

is there a single point of truth for this config and the respective batcher config?

Code quote:

cairo_native_run_config.cairo_native_mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants