central_systest_blobs: add proof tx to test privacy feature#14006
Conversation
PR SummaryLow Risk Overview Updates the expected regression artifacts (blob generation id and Reviewed by Cursor Bugbot for commit dc5d215. Bugbot is set up for automated code reviews on this repo. Configure here. |
80f2783 to
7741718
Compare
69e30f0 to
539ab80
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 699 at r1 (raw file):
.allowed_virtual_os_program_hashes .first() .expect("No allowed virtual OS program hashes in versioned constants");
Is there a constant for that?
I don't like the usage of first here, what if the order of vec changes? (currently it has only one entry)
Code quote:
let program_hash = *block_context
.versioned_constants()
.os_constants
.allowed_virtual_os_program_hashes
.first()
.expect("No allowed virtual OS program hashes in versioned constants");
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware made 1 comment.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 699 at r1 (raw file):
Previously, nimrod-starkware wrote…
Is there a constant for that?
I don't like the usage offirsthere, what if the order of vec changes? (currently it has only one entry)
I think you can use ProgramHashes.virtual_os
539ab80 to
8737d63
Compare
7741718 to
884af7d
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on nimrod-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 699 at r1 (raw file):
Previously, nimrod-starkware wrote…
I think you can use
ProgramHashes.virtual_os
Done.
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
884af7d to
3b9a787
Compare
5c2fb4f to
de29e87
Compare
3b9a787 to
3d97fd4
Compare
3d97fd4 to
fa76e6e
Compare
de29e87 to
dc5d215
Compare

No description provided.