Skip to content

scripts: remove unused --feeder-url from take_nodes_out_of_observer_mode#14008

Merged
ShahakShama merged 1 commit into
mainfrom
shahak/script_remove_unneccesary_args
May 18, 2026
Merged

scripts: remove unused --feeder-url from take_nodes_out_of_observer_mode#14008
ShahakShama merged 1 commit into
mainfrom
shahak/script_remove_unneccesary_args

Conversation

@ShahakShama

Copy link
Copy Markdown
Collaborator

The fetched block number was only used as a soft filter on the post-restart
logs URL. Drop the flag and the related dead plumbing, and refresh the script
title/help text to describe what the script actually does.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk refactor of an operational script: it only changes CLI arguments and the log-explorer query filter, without altering the actual config update/restart behavior.

Overview
Updates scripts/prod/take_nodes_out_of_observer_mode.py to remove the --feeder-url flag and all block-number fetching/printing, since it was only used to soft-filter the post-restart logs link.

The script now generates a logs-explorer URL based solely on the DECISION_REACHED proposer match, and refreshes the CLI description/usage examples to reflect taking nodes out of observer mode via --validator-id-start-from + restart.

Reviewed by Cursor Bugbot for commit 703b96e. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 14d7f04. Configure here.

Comment thread scripts/prod/take_nodes_out_of_observer_mode.py
The fetched block number was only used as a soft filter on the post-restart
logs URL. Drop the flag and the related dead plumbing, and refresh the script
title/help text to describe what the script actually does.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ShahakShama ShahakShama force-pushed the shahak/script_remove_unneccesary_args branch from 14d7f04 to 703b96e Compare May 17, 2026 14:18

@matanl-starkware matanl-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit 0e3a471 May 18, 2026
18 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants