starknet_proof_verifier: accept either PROOF_VERSION_V0 or PROOF_VERSION_V1 in verify_proof

[Yoni-Starkware]

No description provided.

[cursor]

PR Summary

Medium Risk
Changes proof-version validation in the verification path to allow multiple versions, which could affect which proofs are accepted/rejected. The verifier still routes both versions through the same circuit today, so behavioral risk is limited to version-gating and error handling.

Overview
verify_proof now validates the first proof_facts element by parsing it as a ProofVersion, accepting both V0 and V1 instead of hard-rejecting anything other than PROOF_VERSION_V0.

Error reporting is updated accordingly (new “unsupported proof version” message and InvalidProofVersion no longer carries an expected value), and ProgramOutput::try_into_proof_facts writes the version marker via ProofVersion::V0.as_felt() rather than the legacy constant.

^{Reviewed by Cursor Bugbot for commit 19501d4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[Yoni-Starkware]

• workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 039e52c, add v0/v1 aliases #14017
• starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture #14016
• starknet_api,starknet_proof_verifier: write PROOF_VERSION_V1 in try_into_proof_facts #14015
• apollo_starknet_os_program,starknet_os: support PROOF_VERSION_V1 in check_proof_facts #14014
• starknet_proof_verifier: accept either PROOF_VERSION_V0 or PROOF_VERSION_V1 in verify_proof #14013 👈 (View in Graphite)
• starknet_api: add PROOF_VERSION_V1 and accept either marker in ProofFactsVariant #14012
• starknet_api,starknet_proof_verifier: rename PROOF_VERSION to PROOF_VERSION_V0 #14011
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

---

crates/starknet_proof_verifier/src/proof_verifier.rs line 132 at r1 (raw file):

    }

    let proof_version = proof_facts.0.first().copied().unwrap_or_default();

plz extract it to a function proof_fact.proof_version()

Code quote:

proof_facts.0.first()

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

---

crates/starknet_proof_verifier/src/proof_verifier.rs line 25 at r2 (raw file):

        v1_felt = ProofVersion::V1.as_felt(),
        v1_str = ProofVersion::V1.as_str(),
    )]

consider impl debug / display that shows both str and felt

Code quote:

        "Unsupported proof version: got {actual}, expected {v0_felt} ({v0_str}) or {v1_felt} \
         ({v1_str}).",
        v0_felt = ProofVersion::V0.as_felt(),
        v0_str = ProofVersion::V0.as_str(),
        v1_felt = ProofVersion::V1.as_felt(),
        v1_str = ProofVersion::V1.as_str(),
    )]

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on AvivYossef-starkware).

---

crates/starknet_proof_verifier/src/proof_verifier.rs line 25 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

consider impl debug / display that shows both str and felt

Thanks, done

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

[github-actions]

Artifacts upload workflows:

• Started at 2026-05-18T07:44:09Z

[Yoni-Starkware]

@Yoni-Starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 file.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).