apollo_starknet_os_program,starknet_os: support PROOF_VERSION_V1 in check_proof_facts

[Yoni-Starkware]

No description provided.

[cursor]

PR Summary

Medium Risk
Touches Cairo-level check_proof_facts validation logic and updates the OS program hash/bytecode length, which could reject/accept different proof-facts payloads if mis-specified.

Overview
Updates virtual OS proof-facts handling to support both legacy PROOF_VERSION_V0 and new PROOF_VERSION_V1: virtual_os_output.cairo splits PROOF_VERSION into PROOF_VERSION_V0/PROOF_VERSION_V1, and check_proof_facts now explicitly validates the header variant and allows either version.

Propagates the new constants through Rust (Const::ProofVersionV0/Const::ProofVersionV1 and tests), and updates program_hash.json plus the expected OS program bytecode length to match the rebuilt program.

^{Reviewed by Cursor Bugbot for commit 7885760. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[Yoni-Starkware]

• workspace,starknet_proof_verifier: bump privacy-{prove,circuit-verify} to 039e52c, add v0/v1 aliases #14017
• starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture #14016
• starknet_api,starknet_proof_verifier: write PROOF_VERSION_V1 in try_into_proof_facts #14015
• apollo_starknet_os_program,starknet_os: support PROOF_VERSION_V1 in check_proof_facts #14014 👈 (View in Graphite)
• starknet_proof_verifier: accept either PROOF_VERSION_V0 or PROOF_VERSION_V1 in verify_proof #14013
• starknet_api: add PROOF_VERSION_V1 and accept either marker in ProofFactsVariant #14012
• starknet_api,starknet_proof_verifier: rename PROOF_VERSION to PROOF_VERSION_V0 #14011
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion.

---

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/execution/execution_constraints.cairo line 57 at r1 (raw file):

        tempvar v1_diff = proof_header.proof_version - PROOF_VERSION_V1;
        assert v0_diff * v1_diff = 0;
    }

Suggestion:

    // Validate the proof header.
    static_assert ProofHeader.SIZE == 3;
    let proof_header = cast(proof_facts, ProofHeader*);
    assert proof_header.proof_variant = VIRTUAL_SNOS;
    assert is_program_hash_allowed(proof_header.program_hash) = TRUE;
    // Proof variant must be VIRTUAL_SNOS; proof version may be V0 (legacy) or V1 (current).
    with_attr error_message("Unsupported proof version") {
        tempvar proof_version = proof_header.proof_version;
        assert (proof_version - PROOF_VERSION_V1) * (proof_version - PROOF_VERSION_V1) = 0;
    }

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion.

[Yoni-Starkware]

@Yoni-Starkware resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

[graphite-app]

Merge activity

• May 18, 8:34 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
• May 18, 8:34 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

[Yoni-Starkware]

@Yoni-Starkware reviewed 6 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).