Skip to content

starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture#14016

Merged
Yoni-Starkware merged 1 commit into
mainfrom
05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture
May 18, 2026
Merged

starknet_proof_verifier: add v0.14.3 regression case for PROOF_VERSION_V1 fixture#14016
Yoni-Starkware merged 1 commit into
mainfrom
05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture

Conversation

@Yoni-Starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented May 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk: changes are limited to updating example fixture data and expanding a regression test matrix to include Starknet v0.14.3; no production logic changes.

Overview
Updates the shared example_proof_facts.json fixture to use PROOF_VERSION_V1 (changing the first word from ...30 to ...31) and adds a pinned 0.14.3 copy under resources/regression_test/.

Extends regression_verify_proof_from_old_prover to run against the new 0.14.3 fixture so the verifier is continuously checked against proofs generated by that prover version.

Reviewed by Cursor Bugbot for commit acaa303. Bugbot is set up for automated code reviews on this repo. Configure here.

@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from d58cb65 to 6ac567b Compare May 10, 2026 17:01
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 26be1cf to 331d1e2 Compare May 10, 2026 17:01
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from 331d1e2 to bd5effd Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 6ac567b to 963202d Compare May 11, 2026 06:34
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from bd5effd to f8d1581 Compare May 11, 2026 07:23
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 963202d to 1a88611 Compare May 11, 2026 07:23
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from f8d1581 to f5f61b8 Compare May 11, 2026 07:30
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from ef43d9f to 67dfc82 Compare May 11, 2026 07:32
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 03c92c6 to b9bf614 Compare May 11, 2026 07:33
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from 430f38c to c5a9d7f Compare May 11, 2026 07:55
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 23c4d2f to 872e8c6 Compare May 11, 2026 11:35
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from 42bbbd4 to c5110f2 Compare May 11, 2026 11:49
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from 51df181 to f2620df Compare May 11, 2026 12:03
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from c5110f2 to 6e47d4b Compare May 11, 2026 12:03

@AvivYossef-starkware AvivYossef-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@AvivYossef-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from f2620df to e01402c Compare May 17, 2026 09:58
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from 6e47d4b to df403f4 Compare May 17, 2026 09:58
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch from e01402c to 3e1c880 Compare May 18, 2026 09:56
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch 2 times, most recently from 77bd270 to c37c0fe Compare May 18, 2026 11:11
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts branch 2 times, most recently from e9d6c38 to fab4e47 Compare May 18, 2026 12:10
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from c37c0fe to eb4e814 Compare May 18, 2026 12:10
@Yoni-Starkware Yoni-Starkware changed the base branch from 05-10-starknet_api_starknet_proof_verifier_write_proof_version_v1_in_try_into_proof_facts to graphite-base/14016 May 18, 2026 13:54
@Yoni-Starkware Yoni-Starkware force-pushed the 05-10-starknet_proof_verifier_add_v0.14.3_regression_case_for_proof_version_v1_fixture branch from eb4e814 to acaa303 Compare May 18, 2026 13:54
@Yoni-Starkware Yoni-Starkware changed the base branch from graphite-base/14016 to main May 18, 2026 13:54
@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit d8ffcfc May 18, 2026
26 of 30 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants