Skip to content

apollo_gateway: skip archiving proof if transaction is P2P#14022

Open
einat-starkware wants to merge 1 commit into
mainfrom
einat/05-12-apollo_gateway_skip_archiving_proof_if_transaction_is_p2p
Open

apollo_gateway: skip archiving proof if transaction is P2P#14022
einat-starkware wants to merge 1 commit into
mainfrom
einat/05-12-apollo_gateway_skip_archiving_proof_if_transaction_is_p2p

Conversation

@einat-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@einat-starkware einat-starkware marked this pull request as ready for review May 12, 2026 19:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 12, 2026

PR Summary

Medium Risk
Changes the transaction ingestion path to conditionally skip proof archiving based on P2P metadata, which can affect proof persistence and error/forwarding behavior for those transactions.

Overview
Skips the GCS proof-archive write for transactions received via P2P (p2p_message_metadata.is_some()), while still storing proofs in the proof manager, to avoid duplicate archival writes.

Updates the archiving spawn/abort logic to handle an optional archive task, and extends gateway tests to cover both P2P and non-P2P paths (including ensuring mempool forwarding is unaffected by archive failures on the P2P path).

Reviewed by Cursor Bugbot for commit 5965b54. Bugbot is set up for automated code reviews on this repo. Configure here.

@einat-starkware einat-starkware force-pushed the einat/05-12-apollo_gateway_skip_archiving_proof_if_transaction_is_p2p branch 2 times, most recently from 8e081e9 to ff06d28 Compare May 12, 2026 21:25
@einat-starkware einat-starkware force-pushed the einat/05-12-apollo_gateway_skip_archiving_proof_if_transaction_is_p2p branch from ff06d28 to 5965b54 Compare May 12, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants