Skip to content

ci,scripts: install LLVM before cargo tools#14060

Merged
avi-starkware merged 1 commit into
mainfrom
avi/compiler-bootstrap-order-v2
May 18, 2026
Merged

ci,scripts: install LLVM before cargo tools#14060
avi-starkware merged 1 commit into
mainfrom
avi/compiler-bootstrap-order-v2

Conversation

@avi-starkware

Copy link
Copy Markdown
Collaborator

Reorder bootstrap and install_build_tools.sh so LLVM 19 is installed
before cargo tools. This is needed because install_cargo_tools.sh will
install starknet-native-compile which requires LLVM to build.

Safe change: LLVM installation does not depend on Rust.


Re-do of #13674, which was accidentally merged into avi/compiler-verify-fn
instead of main. The change itself (squash commit 08764c4529) is identical;
this PR cherry-picks that commit onto main.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Reorder bootstrap and install_build_tools.sh so LLVM 19 is installed
before cargo tools. This is needed because install_cargo_tools.sh will
install starknet-native-compile which requires LLVM to build.

Safe change: LLVM installation does not depend on Rust.



Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cursor

cursor Bot commented May 17, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Moderate risk because it changes CI/bootstrap ordering and build-tool installation flow, which could break builds if dependencies.sh has implicit assumptions about the Rust toolchain or environment.

Overview
Ensures native build dependencies (via setup_native_deps / dependencies.sh, including LLVM) are installed before Rust/cargo tooling.

This reorders .github/actions/bootstrap to run native deps setup before install_rust, and updates scripts/install_build_tools.sh to execute ./dependencies.sh before install_cargo_tools.sh, adding explicit logging around the dependency step.

Reviewed by Cursor Bugbot for commit 23ee70d. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

Copy link
Copy Markdown

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

@avi-starkware avi-starkware added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit 06a2eeb May 18, 2026
39 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants