apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate

[ShahakShama]

Goal: PR 3 of 6 in the stack moving the STRK/USD oracle into
L1GasPriceProvider. Surfaces the inherent method added in PR 2 on
the client trait so cross-process callers (notably the consensus
orchestrator in PR 5) can request a STRK/USD rate without holding
their own oracle.

Change summary:

• New L1GasPriceRequest::GetStrkToUsdRate(u64) variant.
• New L1GasPriceResponse::GetStrkToUsdRate(L1GasPriceProviderResult<u128>)
  variant.
• New L1GasPriceProviderClient::get_strk_to_usd_rate trait method,
  implemented on the blanket impl mirroring get_rate.
• Server-side dispatch arm in apollo_l1_gas_price::communication
  routes to L1GasPriceProvider::strk_to_usd_rate.

Decision points:

• Did not rename the existing get_rate (which dispatches to
  GetEthToFriRate) for symmetry; out of scope per the stack plan
  and would churn unrelated call sites in consensus orchestrator.
  The trait now has slightly asymmetric naming: get_rate (ETH/FRI)
  vs get_strk_to_usd_rate. Renaming is a separate cleanup if
  desired.
• MockL1GasPriceProviderClient is automock-generated and picks up
  the new method automatically.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

[cursor]

PR Summary

Low Risk
Additive API and observability following the established GetEthToFriRate pattern; no changes to auth, pricing logic, or existing call sites beyond new symbols.

Overview
Exposes STRK/USD lookup on the shared L1GasPriceProvider client so remote callers (e.g. consensus) can fetch rates without a separate oracle.

The change adds GetStrkToUsdRate to the request/response enums, L1GasPriceProviderClient::get_strk_to_usd_rate with the same handle_all_response_variants! path as get_rate (ETH/FRI), and a server dispatch arm to strk_to_usd_rate. Trait docs clarify both rates as 18-decimal fixed-point u128 values.

Dev Grafana gains client- and server-side timeseries panels for request_variant="get_strk_to_usd_rate", matching existing L1 gas price infra metrics.

^{Reviewed by Cursor Bugbot for commit a64cf51. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[ShahakShama]

• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856 : 3 dependent PRs (#13881 , #14216 , #14220 )
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider #14161
• apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays #14160
• apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate #14159 👈 (View in Graphite)
• apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate #14158
• apollo_l1_gas_price: parameterize ExchangeRateOracleClient by metric set #14199
• apollo_l1_gas_price_config,apollo_node: add strk_to_usd_oracle_config #14157
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 1 other dependent PR (#13820 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).

---

crates/apollo_l1_gas_price_types/src/lib.rs line 106 at r1 (raw file):

    async fn get_rate(&self, timestamp: u64) -> L1GasPriceProviderClientResult<u128>;

    async fn get_strk_to_usd_rate(&self, timestamp: u64) -> L1GasPriceProviderClientResult<u128>;

I don't understand the meaning of the u128.
Current ratio is: 1 strk => 0.04$. 1$ ~= 24.5 strk.
So either you have a big rounding error or a truncation to zero.
I think we should use fri as for eth (and the interface should reflect that).

Code quote:

u128

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on matanl-starkware).

---

crates/apollo_l1_gas_price_types/src/lib.rs line 106 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

I don't understand the meaning of the u128.
Current ratio is: 1 strk => 0.04$. 1$ ~= 24.5 strk.
So either you have a big rounding error or a truncation to zero.
I think we should use fri as for eth (and the interface should reflect that).

We show the results with a fixed point decimal of 18 digits
Meaning that if 1$ ~= 24.5 strk the oracle returns 245 * 10^17

[matanl-starkware]

@matanl-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).

---

crates/apollo_l1_gas_price_types/src/lib.rs line 106 at r1 (raw file):

Previously, ShahakShama wrote…

We show the results with a fixed point decimal of 18 digits
Meaning that if 1$ ~= 24.5 strk the oracle returns 245 * 10^17

Should we at least document it somewhere?
Consider moving to FRI, which is a common unit we use everywhere.

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on matanl-starkware).

---

crates/apollo_l1_gas_price_types/src/lib.rs line 106 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Should we at least document it somewhere?
Consider moving to FRI, which is a common unit we use everywhere.

Documented. changing this means coordinating with pragma. Not sure it's worth it

[matanl-starkware]

@matanl-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

[sirandreww-starkware]

@sirandreww-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).