apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays#14160
Conversation
PR SummaryLow Risk Overview
Deployment-side (same stack): Post-merge: regenerate config secrets schema and deployment secrets per PR notes. Reviewed by Cursor Bugbot for commit bcd87e3. Bugbot is set up for automated code reviews on this repo. Configure here. |
722a966 to
7def26d
Compare
f88ac27 to
74796ad
Compare
7def26d to
c291368
Compare
9be64f7 to
ebb9c8e
Compare
570d530 to
a42b523
Compare
bf76248 to
f533d86
Compare
a42b523 to
e413e9a
Compare
f533d86 to
6a5c326
Compare
e413e9a to
403c127
Compare
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
403c127 to
8b42533
Compare
d6f65ca to
76e550e
Compare
8b42533 to
1262c18
Compare
1262c18 to
cfcbbde
Compare
76e550e to
355e1b6
Compare
cfcbbde to
61d4412
Compare
911b2ee to
753bdfc
Compare
266f09d to
f988b4e
Compare
7b8b3a6 to
cb7f91e
Compare
f988b4e to
330b3a9
Compare
330b3a9 to
d3da13d
Compare
cb7f91e to
62290e1
Compare
…_rate Goal: PR 3 of 6 in the stack moving the STRK/USD oracle into L1GasPriceProvider. Surfaces the inherent method added in PR 2 on the client trait so cross-process callers (notably the consensus orchestrator in PR 5) can request a STRK/USD rate without holding their own oracle. Change summary: - New `L1GasPriceRequest::GetStrkToUsdRate(u64)` variant. - New `L1GasPriceResponse::GetStrkToUsdRate(L1GasPriceProviderResult<u128>)` variant. - New `L1GasPriceProviderClient::get_strk_to_usd_rate` trait method, implemented on the blanket impl mirroring `get_rate`. - Server-side dispatch arm in `apollo_l1_gas_price::communication` routes to `L1GasPriceProvider::strk_to_usd_rate`. Decision points: - Did not rename the existing `get_rate` (which dispatches to `GetEthToFriRate`) for symmetry; out of scope per the stack plan and would churn unrelated call sites in consensus orchestrator. The trait now has slightly asymmetric naming: `get_rate` (ETH/FRI) vs `get_strk_to_usd_rate`. Renaming is a separate cleanup if desired. - `MockL1GasPriceProviderClient` is automock-generated and picks up the new method automatically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… overlays Goal: PR 4 of 6 in the stack moving the STRK/USD oracle into L1GasPriceProvider. Lands BEFORE the orchestrator behavior flip (PR 5) so that every test and deployment overlay already points the new `strk_to_usd_oracle_config.url_header_list` at a working endpoint. When PR 5 lands, integration runs immediately exercise the new path with realistic data instead of silently freezing fee_proposal at fee_actual. Change summary: - `create_node_config` takes a new `strk_to_usd_oracle_config: ExchangeRateOracleConfig` argument and plumbs it into `L1GasPriceProviderConfig`. - Callers in `flow_test_setup.rs` and `integration_test_manager.rs` reuse the same dummy `spawn_local_eth_to_strk_oracle` URL for both oracles (the handler returns a constant rate, so semantically equivalent). - `SecretsConfigOverride` in `apollo_deployments::test_utils` gains a `strk_to_usd_oracle_config.url_header_list` field so the generated secrets file covers the new private parameter. - Deployment app-config presets (`l1_gas_price_provider_config.json`, `replacer_l1_gas_price_provider_config.json`) gain the same three per-oracle overrides (`lag_interval_seconds=900`, `max_cache_size=100`, `query_timeout_sec=10`) for STRK/USD, mirroring eth_to_strk. Decision points: - One dummy oracle process serving both feeds instead of spawning two. The fake handler is rate-agnostic — same response shape, single port allocation, same join handle. If we ever need rate-specific dummy values, splitting into two processes is a localized change. Action required after merge (cannot run from this sandbox): - `cargo run --bin update_apollo_node_config_schema` to regenerate `config_secrets_schema.json` (it gains a new private parameter from PR 1's earlier addition). - `cargo run --bin deployment_generator` to regenerate `testing_secrets.json` with the new strk_to_usd entry from `SecretsConfigOverride`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
62290e1 to
bcd87e3
Compare
d3da13d to
a64cf51
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

Goal: PR 4 of 6 in the stack moving the STRK/USD oracle into
L1GasPriceProvider. Lands BEFORE the orchestrator behavior flip
(PR 5) so that every test and deployment overlay already points
the new
strk_to_usd_oracle_config.url_header_listat a workingendpoint. When PR 5 lands, integration runs immediately exercise
the new path with realistic data instead of silently freezing
fee_proposal at fee_actual.
Change summary:
create_node_configtakes a newstrk_to_usd_oracle_config: ExchangeRateOracleConfigargument and plumbs it intoL1GasPriceProviderConfig.flow_test_setup.rsandintegration_test_manager.rsreuse the same dummy
spawn_local_eth_to_strk_oracleURL for bothoracles (the handler returns a constant rate, so semantically
equivalent).
SecretsConfigOverrideinapollo_deployments::test_utilsgainsa
strk_to_usd_oracle_config.url_header_listfield so thegenerated secrets file covers the new private parameter.
(
l1_gas_price_provider_config.json,replacer_l1_gas_price_provider_config.json) gain the same threeper-oracle overrides (
lag_interval_seconds=900,max_cache_size=100,query_timeout_sec=10) for STRK/USD, mirroring eth_to_strk.Decision points:
The fake handler is rate-agnostic — same response shape, single port
allocation, same join handle. If we ever need rate-specific dummy
values, splitting into two processes is a localized change.
Action required after merge (cannot run from this sandbox):
cargo run --bin update_apollo_node_config_schemato regenerateconfig_secrets_schema.json(it gains a new private parameterfrom PR 1's earlier addition).
cargo run --bin deployment_generatorto regeneratetesting_secrets.jsonwith the new strk_to_usd entry fromSecretsConfigOverride.Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com