apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider

[ShahakShama]

Goal: PR 5 of 5 in the stack moving the STRK/USD oracle into
L1GasPriceProvider. This is the behavior flip: compute_snip35_fee_proposal
now asks the gas-price provider client for the STRK/USD rate instead
of holding its own ExchangeRateOracleClientTrait object. With this
in, the orchestrator no longer has direct oracle plumbing — every
external rate goes through the existing SharedL1GasPriceClient seam.

Change summary:

• SequencerConsensusContext::compute_snip35_fee_proposal calls
  self.deps.l1_gas_price_provider.get_strk_to_usd_rate(timestamp).
  The previous Option<Arc<dyn ExchangeRateOracleClientTrait>> outer
  match collapses into a plain Result match; the "freeze fee_proposal"
  fallback is preserved on Err and zero-rate.
• SequencerConsensusContextDeps::strk_to_usd_oracle removed.
• TestDeps::strk_to_usd_oracle removed and the From impl simplified.
• consensus_manager.rs drops the now-invalid strk_to_usd_oracle: None
  field initializer.
• Unused imports cleaned up: ExchangeRateOracleClientTrait and
  MockExchangeRateOracleClientTrait from orchestrator; debug from
  tracing (only used by the dead None branch).
• setup_default_gas_price_provider registers a catch-all
  expect_get_strk_to_usd_rate returning DEFAULT_STRK_TO_USD_RATE
  so existing build_proposal tests keep working without per-test
  expectations.
• The two SNIP-35 fee-proposal tests reorder their per-test mock
  registration to run BEFORE setup_default_expectations, since
  mockall matches expectations in oldest-first order — same pattern
  the codebase already uses for state_sync_client.expect_get_block.
• OracleBehavior::NotConfigured variant removed; the
  no_oracle_freezes_at_fee_actual test case removed (redundant with
  oracle_err_freezes_at_fee_actual — both freeze at fee_actual now
  that there is no on/off switch).

Decision points:

• Original 6-PR plan included a "cleanup" PR removing the oracle
  wiring from apollo_consensus_manager. That PR collapsed into this
  one because this branch forks from BEFORE the wiring was added, so
  the cleanup is one line and shares the same compile-unit constraint.
• The setup_default_gas_price_provider catch-all is needed because
  every build_proposal test now hits compute_snip35_fee_proposal,
  which always queries the provider. The alternative (per-test
  expectations) would have churned ~9 build_proposal call sites.
• DEFAULT_STRK_TO_USD_RATE = 3e17 was picked because the SNIP-35
  test cases treat it as in-bounds.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

[cursor]

PR Summary

Medium Risk
Changes how consensus computes SNIP-35 fee proposals at proposal-build time; behavior on oracle failure is preserved but all rate lookups now go through the shared L1 gas price client.

Overview
SNIP-35 fee proposal logic no longer depends on a separate optional STRK/USD oracle in the orchestrator. compute_snip35_fee_proposal now calls l1_gas_price_provider.get_strk_to_usd_rate(timestamp); the old Option<Arc<dyn ExchangeRateOracleClientTrait>> path and “no oracle configured” branch are removed, while freeze-on-error / zero-rate behavior is unchanged.

SequencerConsensusContextDeps and TestDeps drop strk_to_usd_oracle; consensus_manager stops passing it when building context deps. Tests mock get_strk_to_usd_rate on the gas-price provider (specific expectations registered before the default catch-all) and add DEFAULT_STRK_TO_USD_RATE in setup_default_gas_price_provider so build-proposal tests keep working.

^{Reviewed by Cursor Bugbot for commit 18fee91. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[ShahakShama]

• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856 : 3 dependent PRs (#13881 , #14216 , #14220 )
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider #14161 👈 (View in Graphite)
• apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays #14160
• apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate #14159
• apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate #14158
• apollo_l1_gas_price: parameterize ExchangeRateOracleClient by metric set #14199
• apollo_l1_gas_price_config,apollo_node: add strk_to_usd_oracle_config #14157
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 1 other dependent PR (#13820 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

---

crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs line 457 at r1 (raw file):

        SNIP35_FEE_ACTUAL.set_lossy(fee_actual.0);

        let fee_target = match self.deps.l1_gas_price_provider.get_strk_to_usd_rate(timestamp).await

Should verify the units.
IIUC, the fee should be in FRI.

Code quote:

let fee_target

[ShahakShama]

@ShahakShama reviewed 4 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

[sirandreww-starkware]

@sirandreww-starkware partially reviewed 4 files.
Reviewable status: 4 of 10 files reviewed, all discussions resolved (waiting on matanl-starkware).

[sirandreww-starkware]

@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).