starknet_committer,apollo_committer: add timers for fetch patricia paths

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• apollo_committer: reduce tests boilerplate #14425
• apollo_committer: test new edge bottom in witnesses #14388
• apollo_committer: add request_paths_and_commit_block tests #14208
• starknet_patricia: add storage proof verification #14296
• apollo_committer: add new request handler #14003
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189 👈 (View in Graphite)
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• apollo_committer_types: add patricia proofs request and response types #13996 : 1 other dependent PR (#13997 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Observability-only changes behind os_input; no commit logic, storage, or witness content changes.

Overview
Under the os_input feature, block commit instrumentation now times pre-commit and post-commit Patricia witness collection separately and records how many witness entries came from the first pass.

The read_paths_and_commit_block tip flow starts end-to-end measurements before the first witness fetch, stops timers around each fetch_patricia_witnesses call (using get_nodes_count() on merged proofs), and extends debug logs with pre/post fetch durations in ms and total witness entry count. StarknetForestProofs::get_nodes_count() replaces duplicated inline counting for logging.

^{Reviewed by Cursor Bugbot for commit 2f2eaad. Bugbot is set up for automated code reviews on this repo. Configure here.}

[ArielElp]

@ArielElp resolved 3 discussions.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 134 at r9 (raw file):

Previously, yoavGrs wrote…

With the feature flag

Done.

[yoavGrs]

@yoavGrs reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp and dorimedini-starkware).

---

crates/starknet_committer/src/patricia_merkle_tree/types.rs line 72 at r13 (raw file):

        self.classes_trie_proof.len()
            + self.contracts_trie_proof.nodes.len()
            + self.contracts_trie_proof.leaves.len()

You did both modifications. Does clippy complain if you rename it back to len?

Code quote:

    pub fn get_nodes_count(&self) -> usize {
        self.classes_trie_proof.len()
            + self.contracts_trie_proof.nodes.len()
            + self.contracts_trie_proof.leaves.len()

[dorimedini-starkware]

@dorimedini-starkware reviewed 4 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on ArielElp).

---

crates/apollo_committer/src/committer.rs line 623 at r13 (raw file):

                     {deleted_nodes_count} nodes",
                    witness_count = patricia_proofs.get_nodes_count(),
                    deleted_nodes_count = deleted_nodes.len(),

what about the proof_after count?

Code quote:

                    witness_count = patricia_proofs.get_nodes_count(),
                    deleted_nodes_count = deleted_nodes.len(),

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 168 at r13 (raw file):

            #[cfg(feature = "os_input")]
            Action::FetchWitnessesSecondPass => {
                self.durations.fetch_witnesses_second_pass = duration_in_seconds;

why aren't you counting the second pass...? overlap?

Code quote:

self.durations.fetch_witnesses_second_pass = duration_in_seconds;

---

crates/starknet_committer_cli/Cargo.toml at r13 (raw file):
is starknet_committer_cli covered in Yoav's workflow?

[ArielElp]

@ArielElp made 3 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/apollo_committer/src/committer.rs line 623 at r13 (raw file):

Previously, dorimedini-starkware wrote…

what about the proof_after count?

Mostly to not have to account for overlap, partly because we know this step is less significant, and measure time in any case to make sure it's not problematic.

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 168 at r13 (raw file):

Previously, dorimedini-starkware wrote…

why aren't you counting the second pass...? overlap?

See above.

---

crates/starknet_committer/src/patricia_merkle_tree/types.rs line 72 at r13 (raw file):

Previously, yoavGrs wrote…

You did both modifications. Does clippy complain if you rename it back to len?

Yes, if there's len it wants is_empty, but the new name is probably better.

[dorimedini-starkware]

@dorimedini-starkware resolved 2 discussions.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on ArielElp and yoavGrs).

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/starknet_committer_cli/Cargo.toml at r13 (raw file):

Previously, dorimedini-starkware wrote…

is starknet_committer_cli covered in Yoav's workflow?

It is not, but also not needed, this is a remainder after some cleanup in earlier versions, removed.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2f2eaad. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on ArielElp and yoavGrs).

[ArielElp]

@ArielElp resolved 4 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).