apollo_consensus_orchestrator: rename snip35 module to dynamic_gas_price, scrub SNIP-35 comments

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-05-27T11:10:25Z
• Started at 2026-05-27T11:52:39Z
• Started at 2026-05-27T13:31:33Z
• Started at 2026-05-27T14:47:29Z
• Started at 2026-05-27T14:47:54Z

[sirandreww-starkware]

• apollo_consensus_orchestrator: rename snip35 module to dynamic_gas_price, scrub SNIP-35 comments #14216 👈 (View in Graphite)
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856 : 2 other dependent PRs (#13881 , #14220 )
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider #14161
• apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays #14160
• apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate #14159
• apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate #14158
• apollo_l1_gas_price: parameterize ExchangeRateOracleClient by metric set #14199
• apollo_l1_gas_price_config,apollo_node: add strk_to_usd_oracle_config #14157
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 1 other dependent PR (#13820 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware partially reviewed 26 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on sirandreww-starkware).

---

crates/apollo_dashboard/src/panels/consensus.rs line 726 at r1 (raw file):

fn get_panel_snip35_fee_actual() -> Panel {
    Panel::new(
        "SNIP-35 - fee_actual (GFri)",

Remove this prefix from all the panels, it's already under the SNIP-35 row.

Code quote:

SNIP-35 - 

---

crates/apollo_dashboard/src/panels/consensus.rs line 797 at r1 (raw file):

pub(crate) fn get_snip35_row() -> Row {
    Row::new(
        "SNIP-35 - Dynamic Gas Price",

Suggestion:

Dynamic Gas Price (SNIP-35)

[cursor]

PR Summary

Low Risk
Comment, module path, and symbol renames only; no algorithm or protocol field changes in the diff.

Overview
This PR is a naming and documentation cleanup for the consensus dynamic L2 gas fee mechanism: the orchestrator module snip35 is exposed as dynamic_gas_price, and imports across consensus orchestrator, cende, tests, protobuf comments, storage, API types, and related crates are updated accordingly.

Behavior is unchanged. Fee math, validation, and wire formats stay the same; only labels move from “SNIP-35” toward neutral terms (e.g. fee_proposals window, V0_14_3+) and one internal helper is renamed compute_snip35_fee_proposal → compute_proposer_fee_proposal. Validator messaging drops the “SNIP-35 bounds” wording; a TODO tag is retargeted to AndrewL.

Grafana/dashboard copy is refreshed (row “Dynamic Gas Price (SNIP-35)”, shorter panel titles); Prometheus metric names such as snip35_fee_actual are not renamed in this diff.

^{Reviewed by Cursor Bugbot for commit 8d2400d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 24 of 26 files reviewed, 2 unresolved discussions (waiting on matanl-starkware).

---

crates/apollo_dashboard/src/panels/consensus.rs line 726 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Remove this prefix from all the panels, it's already under the SNIP-35 row.

Done.

---

crates/apollo_dashboard/src/panels/consensus.rs line 797 at r1 (raw file):

pub(crate) fn get_snip35_row() -> Row {
    Row::new(
        "SNIP-35 - Dynamic Gas Price",

Done.

[matanl-starkware]

@matanl-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

---

crates/apollo_dashboard/src/panels/consensus.rs line 726 at r2 (raw file):

fn get_panel_snip35_fee_actual() -> Panel {
    Panel::new(
        "fee_actual (GFri)",

All panels should have the same style (Title Case).
e.g. "Seconds Since Last Successful STRK→USD Rate Update"

Code quote:

fee_actual (GFri)

[matanl-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

[sirandreww-starkware]

@sirandreww-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 23 of 26 files reviewed, all discussions resolved (waiting on matanl-starkware).

---

crates/apollo_dashboard/src/panels/consensus.rs line 726 at r2 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

All panels should have the same style (Title Case).
e.g. "Seconds Since Last Successful STRK→USD Rate Update"

Done

[sirandreww-starkware]

@sirandreww-starkware partially reviewed 26 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).