apollo_consensus_orchestrator: make SNIP-35 fee target a dynamic config

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Changes consensus proposer fee targets and default economics ($3e-9 → $0.88 per 1e9 L2 gas atto-USD); misconfiguration could skew L2 base fees across the network.

Overview
Moves the SNIP-35 target USD cost per L2 gas from a hardcoded orchestrator constant to ContextDynamicConfig.snip35_target_atto_usd_per_l2_gas, so operators can tune it without a code change.

The proposer’s compute_proposer_fee_proposal now takes that value and build_proposal reads it from self.config.dynamic_config. The shared default is DEFAULT_SNIP35_TARGET_ATTO_USD_PER_L2_GAS (880_000_000 atto-USD), replacing the old compile-time 3_000_000_000 target. Deployment app configs and config_schema.json are updated to expose the new field (deployed value 880000000).

^{Reviewed by Cursor Bugbot for commit 9f3c029. Bugbot is set up for automated code reviews on this repo. Configure here.}

[sirandreww-starkware]

• apollo_dashboard: make SNIP-35 fee target USD panel a stat #14293
• deployment: wait for node healthcheck before starting the simulator #14225
• deployment: add N_NODES flag to run multiple nodes in local monitoring stack #14224
• deployment: support real Pragma oracle in local monitoring stack #14223
• apollo_consensus_orchestrator: pin SNIP-35 fee_target to override_l2_gas_price_fri when set #14230
• apollo_consensus_orchestrator,apollo_dashboard: add USD fee target panel and unit suffixes #14228
• apollo_consensus_orchestrator: make SNIP-35 fee target a dynamic config #14220 👈 (View in Graphite)
• main-v0.14.3

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on sirandreww-starkware).

---

crates/apollo_node/resources/config_schema.json line 2732 at r1 (raw file):

    "value": true
  },
  "consensus_manager_config.context_config.dynamic_config.snip35_target_atto_usd_per_l2_gas": {

You should run cargo run --bin deployment_generator

Code quote:

consensus_manager_config.context_config.dynamic_config.snip35_target_atto_usd_per_l2_gas

---

crates/apollo_node/resources/config_schema.json line 2736 at r1 (raw file):

    "privacy": "Public",
    "value": 880000000
  },

I think this value should be different per env. Make it env-dependent by using the $$$ replacer concept.

Code quote:

  },
  "consensus_manager_config.context_config.dynamic_config.snip35_target_atto_usd_per_l2_gas": {
    "description": "SNIP-35 target USD cost per L2 gas unit, in atto-USD ($0.88 per 1e9 L2 gas = 880_000_000 atto-USD).",
    "privacy": "Public",
    "value": 880000000
  },

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 5 of 13 files reviewed, 2 unresolved discussions (waiting on matanl-starkware and sirandreww-starkware).

---

crates/apollo_node/resources/config_schema.json line 2732 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

You should run cargo run --bin deployment_generator

Done.

---

crates/apollo_node/resources/config_schema.json line 2736 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

I think this value should be different per env. Make it env-dependent by using the $$$ replacer concept.

Done
Would you like there to be different values now? Why do you suspect it should be different between envs?

[matanl-starkware]

@matanl-starkware reviewed 8 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

---

crates/apollo_node/resources/config_schema.json line 2736 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

Done
Would you like there to be different values now? Why do you suspect it should be different between envs?

I guess POTC ans Starknet have a different price target.

[sirandreww-starkware]

@sirandreww-starkware made 1 comment.
Reviewable status: 8 of 15 files reviewed, 1 unresolved discussion (waiting on matanl-starkware and sirandreww-starkware).

---

crates/apollo_node/resources/config_schema.json line 2736 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

I guess POTC ans Starknet have a different price target.

asked Ohad, he said they override the value there

[ShahakShama]

@ShahakShama reviewed 15 files and all commit messages, made 2 comments, resolved 1 discussion, and dismissed @matanl-starkware from a discussion.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on sirandreww-starkware).

---

crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 1688 at r3 (raw file):

    let mut context = deps.build_context();
    context.l2_gas_price = l2_gas_price;
    let proposal = context.compute_proposer_fee_proposal(fee_actual, 0, 3_000_000_000).await;

Extract to a constant

---

crates/apollo_deployments/src/service.rs line 71 at r3 (raw file):

    "consensus_manager_config.context_config.dynamic_config.override_l2_gas_price_fri.#is_none",
    "consensus_manager_config.context_config.dynamic_config.override_l2_gas_price_fri",
    "consensus_manager_config.context_config.dynamic_config.snip35_target_atto_usd_per_l2_gas",

I thought you said we don't want this here

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 11 of 15 files reviewed, 2 unresolved discussions (waiting on matanl-starkware, ShahakShama, and sirandreww-starkware).

---

crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 1688 at r3 (raw file):

Previously, ShahakShama wrote…

Extract to a constant

Done

---

crates/apollo_deployments/src/service.rs line 71 at r3 (raw file):

Previously, ShahakShama wrote…

I thought you said we don't want this here

will do in a future PR

[ShahakShama]

@ShahakShama reviewed 4 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

---

crates/apollo_deployments/src/service.rs line 71 at r3 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

will do in a future PR

Do it here as discussed

[ShahakShama]

@ShahakShama reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

[sirandreww-starkware]

@sirandreww-starkware made 1 comment and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

---

crates/apollo_deployments/src/service.rs line 71 at r3 (raw file):

Previously, ShahakShama wrote…

Do it here as discussed

Done.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7da3e50. Configure here.}

OOO, his comments were adressed

[sirandreww-starkware]

@sirandreww-starkware reviewed 15 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).