Skip to content

apollo_consensus_orchestrator,apollo_dashboard: add USD fee target panel and unit suffixes#14228

Merged
sirandreww-starkware merged 1 commit into
main-v0.14.3from
05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes
May 28, 2026
Merged

apollo_consensus_orchestrator,apollo_dashboard: add USD fee target panel and unit suffixes#14228
sirandreww-starkware merged 1 commit into
main-v0.14.3from
05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes

Conversation

@sirandreww-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this May 28, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review May 28, 2026 06:12
@cursor

cursor Bot commented May 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only metric renames and a new gauge; no consensus or fee logic changes beyond recording the configured USD target.

Overview
SNIP-35 observability now names Fri gauges explicitly (snip35_fee_*_fri) and adds snip35_fee_target_atto_usd, set when the proposer computes fee_proposal from snip35_target_atto_usd_per_l2_gas.

Grafana’s Dynamic Gas Price (SNIP-35) row picks up the renamed PromQL and a new Fee Target (USD per 1B L2 gas) panel (atto_usd / 1e9). Consensus orchestrator and dashboard code stay aligned on the same metric constants.

Reviewed by Cursor Bugbot for commit 719af13. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from c27b590 to bb273c7 Compare May 28, 2026 08:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-apollo_consensus_orchestrator_make_snip-35_fee_target_a_dynamic_config branch 2 times, most recently from a16613e to 7da3e50 Compare May 28, 2026 08:05
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch 2 times, most recently from cfefa39 to 728099a Compare May 28, 2026 08:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-27-apollo_consensus_orchestrator_make_snip-35_fee_target_a_dynamic_config branch 2 times, most recently from 6bd9fa3 to 9f3c029 Compare May 28, 2026 08:17
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from 728099a to 37cd335 Compare May 28, 2026 08:17

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@graphite-app graphite-app Bot changed the base branch from 05-27-apollo_consensus_orchestrator_make_snip-35_fee_target_a_dynamic_config to main-v0.14.3 May 28, 2026 08:38
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from 37cd335 to 719af13 Compare May 28, 2026 08:38

@sirandreww-starkware sirandreww-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants