Skip to content

starknet_transaction_prover: unify HTTP middleware stack via macro#14286

Merged
avi-starkware merged 1 commit into
main-v0.14.3from
avi/prover-v3/middleware-macro
Jul 2, 2026
Merged

starknet_transaction_prover: unify HTTP middleware stack via macro#14286
avi-starkware merged 1 commit into
main-v0.14.3from
avi/prover-v3/middleware-macro

Conversation

@avi-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@avi-starkware avi-starkware marked this pull request as ready for review June 1, 2026 11:22
@cursor

cursor Bot commented Jun 1, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Refactor-only: same middleware layers and order as before; risk is limited to accidental drift if future edits miss updating the macro or call-site imports.

Overview
Unifies the JSON-RPC HTTP middleware stack so plain HTTP (start_server) and HTTPS (tls::start_tls_server) share one definition instead of two copy-pasted ServiceBuilder chains.

Adds prover_http_middleware! in server.rs (placed above pub mod tls so tls.rs can expand it) and wires both transports to prover_http_middleware!(cors_layer, ohttp_layer). Inline layer-order comments at the call sites are replaced with pointers to the macro docs, which now hold the full rationale (health outermost, OHTTP outside compression, body mapping for HttpBody).

Reviewed by Cursor Bugbot for commit 05aa1a7. Bugbot is set up for automated code reviews on this repo. Configure here.

@avi-starkware avi-starkware force-pushed the avi/prover-v3/middleware-macro branch from f81df1e to 4b74749 Compare June 7, 2026 10:11

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

@avi-starkware avi-starkware added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main-v0.14.3 with commit 750c3bb Jul 2, 2026
20 checks passed

Copy link
Copy Markdown
Contributor

Security scan complete — no issues detected.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants