deployment: thread config_format from CLI to node container arg#14608
deployment: thread config_format from CLI to node container arg#14608nimrod-starkware wants to merge 1 commit into
Conversation
e8502f3 to
8967b72
Compare
08a9e6a to
fa2de48
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware made 2 comments.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions.
deployments/sequencer/src/charts/node.py line 34 at r1 (raw file):
layout: str, overlays: list[str], config_format: str = "preset",
no default value, remove
Code quote:
config_format: str = "preset",deployments/sequencer/src/constructs/deployment.py line 14 at r1 (raw file):
labels, monitoring_endpoint_port, config_format: str = "preset",
no default value, remove
Code quote:
config_format: str = "preset",
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware resolved 2 discussions.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.
fa2de48 to
78a4998
Compare
8967b72 to
98a58a8
Compare
PR SummaryLow Risk Overview The value flows from ConfigMap content for Reviewed by Cursor Bugbot for commit 0df19b8. Bugbot is set up for automated code reviews on this repo. Configure here. |
78a4998 to
601f1fd
Compare
98a58a8 to
528af92
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 528af92. Configure here.
601f1fd to
bfabe31
Compare
528af92 to
9b6dcf2
Compare
bfabe31 to
b2bea5e
Compare
9b6dcf2 to
8032897
Compare
b2bea5e to
e8bbbb7
Compare
8032897 to
509c630
Compare
Add a `--config-format {preset,native}` deployment CLI flag (default preset) and
thread its value from the parser through SequencerNodeChart and the
Deployment/StatefulSet constructs to PodBuilder, which now emits
`--config_format <value>` to the node container instead of a hardcoded "preset".
With the default (preset) the synthesized output is unchanged. The ConfigMap
content path (native config generation) consumes this value in a follow-up.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
e8bbbb7 to
6ca2fa5
Compare
509c630 to
0df19b8
Compare


Add a
--config-format {preset,native}deployment CLI flag (default preset) andthread its value from the parser through SequencerNodeChart and the
Deployment/StatefulSet constructs to PodBuilder, which now emits
--config_format <value>to the node container instead of a hardcoded "preset".With the default (preset) the synthesized output is unchanged. The ConfigMap
content path (native config generation) consumes this value in a follow-up.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com