Skip to content

deployment: thread config_format from CLI to node container arg#14608

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/storage-reader-portsfrom
nimrod/jsonnet/config-format-arg
Open

deployment: thread config_format from CLI to node container arg#14608
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/storage-reader-portsfrom
nimrod/jsonnet/config-format-arg

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Add a --config-format {preset,native} deployment CLI flag (default preset) and
thread its value from the parser through SequencerNodeChart and the
Deployment/StatefulSet constructs to PodBuilder, which now emits
--config_format <value> to the node container instead of a hardcoded "preset".
With the default (preset) the synthesized output is unchanged. The ConfigMap
content path (native config generation) consumes this value in a follow-up.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

nimrod-starkware commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/config-format-arg branch from e8502f3 to 8967b72 Compare June 23, 2026 11:58
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/storage-reader-ports branch from 08a9e6a to fa2de48 Compare June 23, 2026 11:58

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware made 2 comments.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions.


deployments/sequencer/src/charts/node.py line 34 at r1 (raw file):

        layout: str,
        overlays: list[str],
        config_format: str = "preset",

no default value, remove

Code quote:

config_format: str = "preset",

deployments/sequencer/src/constructs/deployment.py line 14 at r1 (raw file):

        labels,
        monitoring_endpoint_port,
        config_format: str = "preset",

no default value, remove

Code quote:

config_format: str = "preset",

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware resolved 2 discussions.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.

@cursor

cursor Bot commented Jun 25, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Default remains preset so existing synth output is unchanged; only non-default native changes runtime config loading, and ConfigMap generation is not wired yet.

Overview
Adds --config-format (preset | native, default preset) to the sequencer deployment CLI so operators can choose how the node loads config.

The value flows from app.pySequencerNodeChartDeployment/StatefulSet constructs → PodBuilder, which now passes --config_format <value> to the container instead of always preset. With the default, synthesized manifests match prior behavior.

ConfigMap content for native is explicitly out of scope here (follow-up PR).

Reviewed by Cursor Bugbot for commit 0df19b8. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/storage-reader-ports branch from 78a4998 to 601f1fd Compare June 28, 2026 08:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/config-format-arg branch from 98a58a8 to 528af92 Compare June 28, 2026 08:19

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 528af92. Configure here.

Comment thread deployments/sequencer/src/charts/node.py
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/storage-reader-ports branch from 601f1fd to bfabe31 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/config-format-arg branch from 528af92 to 9b6dcf2 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/storage-reader-ports branch from bfabe31 to b2bea5e Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/config-format-arg branch from 9b6dcf2 to 8032897 Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/storage-reader-ports branch from b2bea5e to e8bbbb7 Compare July 1, 2026 08:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/config-format-arg branch from 8032897 to 509c630 Compare July 1, 2026 08:25
Add a `--config-format {preset,native}` deployment CLI flag (default preset) and
thread its value from the parser through SequencerNodeChart and the
Deployment/StatefulSet constructs to PodBuilder, which now emits
`--config_format <value>` to the node container instead of a hardcoded "preset".
With the default (preset) the synthesized output is unchanged. The ConfigMap
content path (native config generation) consumes this value in a follow-up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants