Skip to content

deployment,ci: add hybrid native override layers and their validation tests#14610

Closed
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-override-commonfrom
nimrod/jsonnet/native-override-layers
Closed

deployment,ci: add hybrid native override layers and their validation tests#14610
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-override-commonfrom
nimrod/jsonnet/native-override-layers

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Add the base (common) and sepolia-integration sequencer_config.jsonnet override
layers consumed by the native config builder, plus the tests that validate them:
the AUTHORITATIVE PARITY test (native build vs folded/filtered preset across
hundreds of applicative keys) with its negative gate, the "jsonnet mirrors combined
YAML" layer tests, and the cross-repo overlay collision / disjoint-leaf-key guards.
The devops-dependent tests skip cleanly when the devops overlay checkout is absent
(as in CI). Run the full test/ pytest suite in the cdk8s CI workflow instead of
only the port-uniqueness test, so these gate in CI.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

nimrod-starkware commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split to two separate PR's

@nimrod-starkware made 2 comments.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion.


.github/workflows/sequencer_cdk8s-test.yml line 74 at r2 (raw file):

          echo "Installing pip dependencies..."
          pipenv install
          echo "Running pytest suite..."

this change should be in prev PR

Code quote:

echo "Running pytest suite..."

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware resolved 1 discussion.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.

@nimrod-starkware nimrod-starkware changed the base branch from nimrod/jsonnet/native-config-builder to graphite-base/14610 June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/native-override-layers branch from 099442e to 635f6e5 Compare June 28, 2026 10:14
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/14610 to nimrod/jsonnet/native-override-common June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/native-override-layers branch from 635f6e5 to bdaadc1 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/native-override-common branch from 5950d10 to 5ed6bbd Compare June 28, 2026 10:30
…ckstep test

Add the sepolia-integration env sequencer_config.jsonnet override layer consumed by the native config builder, plus its per-layer lockstep test: the layer's jsonnet, flattened to dotted keys, must exactly match the combined config.sequencerConfig of the sepolia-integration YAMLs (with #is_none folded and components.* dropped), keeping the native and preset generation paths from drifting.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware self-assigned this Jun 28, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 28, 2026 12:06
@cursor

cursor Bot commented Jun 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Additive integration-environment deployment config guarded by an existing parity test pattern; no runtime code paths change in this diff.

Overview
Adds the hybrid sepolia-integration native override sequencer_config.jsonnet, so the nested config builder can apply the same integration-specific sequencer settings as the YAML overlays (chain/feeder URLs, L1 block anchors, batcher limits, consensus committee defaults, gateway bucket, state sync, etc.).

Extends the native config lockstep regression from the common layer only to every overlay layer: docs/comments now describe per-layer parity, and test_integration_layer_jsonnet_mirrors_combined_yaml asserts the new jsonnet matches the folded combined config.sequencerConfig from that layer’s YAMLs.

Reviewed by Cursor Bugbot for commit 0034285. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants