apollo_integration_tests,apollo_node_config: load integration-test node config via native format#14629
Conversation
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion.
crates/apollo_integration_tests/src/executable_setup.rs line 109 at r1 (raw file):
/// Config files passed to the native loader, base first then secrets, matching the /// `[base, secret]` arity expected by `load_native`. pub fn node_config_paths(&self) -> Vec<PathBuf> {
Suggestion:
pub(crate) fn node_config_paths(&self) -> [PathBuf; 2] {ad01662 to
81e18a7
Compare
2e11c32 to
aa981cd
Compare
81e18a7 to
4614c66
Compare
aa981cd to
cfcf68f
Compare
4614c66 to
76ce25d
Compare
cfcf68f to
ab93940
Compare
76ce25d to
0797ffc
Compare
PR SummaryLow Risk Overview Config artifacts: The harness writes a nested base JSON (via new Node spawn: Preset dumping ( Reviewed by Cursor Bugbot for commit 3918577. Bugbot is set up for automated code reviews on this repo. Configure here. |
ab93940 to
bca6dd7
Compare
0797ffc to
402a491
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 402a491. Configure here.
…de config via native format
Make the integration-test harness emit a nested native config artifact plus a
secrets file and boot the node with --config_format native (two --config_file
paths: nested base first, flat secrets second), instead of the legacy preset
single-file path. Adds as_native_value/dump_native_config_file alongside the
retained preset as_value, a {} secrets file, and node_config_paths() returning
[base, secrets]; both spawn_run_node call sites pass the two-file vector.
This is the prerequisite that lets the integration suite exercise the native
load path before the preset path is torn down.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bca6dd7 to
6d40587
Compare
402a491 to
3918577
Compare


Make the integration-test harness emit a nested native config artifact plus a
secrets file and boot the node with --config_format native (two --config_file
paths: nested base first, flat secrets second), instead of the legacy preset
single-file path. Adds as_native_value/dump_native_config_file alongside the
retained preset as_value, a {} secrets file, and node_config_paths() returning
[base, secrets]; both spawn_run_node call sites pass the two-file vector.
This is the prerequisite that lets the integration suite exercise the native
load path before the preset path is torn down.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com