apollo_config: make native the sole config-load path#14631
apollo_config: make native the sole config-load path#14631nimrod-starkware wants to merge 1 commit into
Conversation
22984a6 to
407157e
Compare
d8e24ea to
06da659
Compare
06da659 to
5eb5701
Compare
407157e to
9b677ae
Compare
5eb5701 to
ec5b1f7
Compare
9b677ae to
de0822e
Compare
de0822e to
e752ded
Compare
ec5b1f7 to
ff18571
Compare
PR SummaryHigh Risk Overview
Reviewed by Cursor Bugbot for commit 71cb679. Bugbot is set up for automated code reviews on this repo. Configure here. |
ff18571 to
8492d9d
Compare
Delete the preset branch of load_and_process_config so load_native is the only loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI override parser (build_args_parser/update_config_map_by_command_args), the load-time config_schema.json read, the pointer-resolution and #is_none-folding functions (split_pointers_map, split_values_and_types, update_config_map_by_pointers, update_optional_values), and the config_parity dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS, CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for later phases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
8492d9d to
71cb679
Compare
2c485b4 to
f7f7322
Compare

Delete the preset branch of load_and_process_config so load_native is the only
loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI
override parser (build_args_parser/update_config_map_by_command_args), the
load-time config_schema.json read, the pointer-resolution and #is_none-folding
functions (split_pointers_map, split_values_and_types,
update_config_map_by_pointers, update_optional_values), and the config_parity
dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS,
CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for
later phases.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com