Skip to content

deployment: add dummy_for_testing native config override layer#14632

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-sole-loadfrom
nimrod/jsonnet/dummy-for-testing-native-layer
Open

deployment: add dummy_for_testing native config override layer#14632
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-sole-loadfrom
nimrod/jsonnet/dummy-for-testing-native-layer

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

The prepare-production-overlays CI job synths each prod overlay env-only
(-o hybrid. -o hybrid.common.dummy_for_testing), with no per-node leaf or
devops checkout. Under the native config path this errored on a missing
overrides.validator_id (and the consensus/mempool multiaddrs) because the
dummy_for_testing overlay had YAML but no native sequencer_config.jsonnet. Add
that layer (the folded nested translation of dummy_for_testing's YAMLs:
validator_id plus the #is_none multiaddrs as null) so env-only native synth
succeeds for mainnet, sepolia-alpha and sepolia-integration. Add the matching
*_layer_jsonnet_mirrors_combined_yaml regression test.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

nimrod-starkware commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 3765446 to 8a5e826 Compare June 28, 2026 08:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 06da659 to 5eb5701 Compare June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 8a5e826 to 082340c Compare June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 5eb5701 to ec5b1f7 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 082340c to 8852b34 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from ec5b1f7 to ff18571 Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 8852b34 to 0114f91 Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware self-assigned this Jun 29, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 29, 2026 06:47
@cursor

cursor Bot commented Jun 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only dummy deployment config with no production runtime behavior; changes are limited to test/overlay synthesis inputs.

Overview
Adds native jsonnet override layers under hybrid/common/dummy_for_testing so env-only overlay synthesis (e.g. prepare-production-overlays with hybrid.<env> + hybrid.common.dummy_for_testing) no longer fails on missing native fields.

node_params.jsonnet supplies a stand-in validator_id (0x64), and chain_params.jsonnet sets consensus and mempool P2P advertised_multiaddr / bootstrap_peer_multiaddr to null, matching the existing dummy YAML semantics for CI without a devops checkout.

Reviewed by Cursor Bugbot for commit 1c52bdc. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants