Skip to content

deployment: add native config layers for the testing overlays#14645

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/dummy-for-testing-native-layerfrom
nimrod/jsonnet/testing-overlays-native-layers
Open

deployment: add native config layers for the testing overlays#14645
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/dummy-for-testing-native-layerfrom
nimrod/jsonnet/testing-overlays-native-layers

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Under the native config path an overlay's config comes from sequencer_config.jsonnet
layers (YAML sequencerConfig is ignored). The testing/node-0 and testing/all-constructs
overlays (synthed by the cdk8s-test and hybrid-system-test CI jobs) had no native layer,
so native synth aborted on unconditionally-read overrides.* keys (validator_id, the outer
committer cache_size, ...).

  • testing/node-0: full value-parity native layer (the folded translation of its combined
    YAML sequencerConfig). It is deployed live by hybrid_system_test, so values are
    load-bearing; guarded by a strict mirror test (test_node0_layer_jsonnet_mirrors_combined_yaml).
  • testing/all-constructs: a structure-validation stub supplying exactly the unconditional
    overrides.* reads the base layer does not provide, with clearly-dummy immaterial values
    (its synth is only kubectl-validated for manifest structure); guarded by a synth-success
    test (test_all_constructs_native_config_synthesizes).

This lets every CI-synthed overlay build under native, before the default flip.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 39a3bb3 to e704bbc Compare June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from e704bbc to b9c5305 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 082340c to 8852b34 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from b9c5305 to 66a55ac Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware self-assigned this Jun 29, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 29, 2026 06:48
@cursor

cursor Bot commented Jun 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to test/CI overlay config and a unit test; no sequencer runtime or auth logic is modified.

Overview
Adds native hybrid overlay jsonnet (chain_params, node_params, replacers) for testing/all-constructs and testing/node-0 so cdk8s can synthesize under --config-format native without failing on required overrides.* keys (e.g. validator_id, committer cache).

testing/all-constructs uses clearly dummy values—only enough for native synth and manifest structure validation in CI. testing/node-0 carries real integration-style chain settings (Sepolia URL, BPO block numbers, fee tokens, batcher/consensus/gateway deltas) aligned with the overlay used by hybrid system tests.

test_native_config.py now asserts build_native_config succeeds for hybrid.testing.all-constructs and returns a non-empty nested dict.

Reviewed by Cursor Bugbot for commit d96316b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 77abc10. Configure here.

'state_sync_config.static_config.central_sync_client_config': null,
'state_sync_config.static_config.network_config': {
port: 55010,
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing P2P sync replacer entry

High Severity

The testing/node-0 native replacers set state_sync_config.static_config.central_sync_client_config to null and configure P2P network_config, but omit a replacer to enable p2p_sync_client_config. The overlay YAML explicitly turns P2P sync on, so native synthesis leaves both sync clients disabled and breaks the load-bearing hybrid test layout once native config is used.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 77abc10. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants