deployment: add native config layers for the testing overlays#14645
Conversation
39a3bb3 to
e704bbc
Compare
e704bbc to
b9c5305
Compare
082340c to
8852b34
Compare
b9c5305 to
66a55ac
Compare
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit d96316b. Bugbot is set up for automated code reviews on this repo. Configure here. |
0114f91 to
e667fd9
Compare
66a55ac to
77abc10
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 77abc10. Configure here.
| 'state_sync_config.static_config.central_sync_client_config': null, | ||
| 'state_sync_config.static_config.network_config': { | ||
| port: 55010, | ||
| }, |
There was a problem hiding this comment.
Missing P2P sync replacer entry
High Severity
The testing/node-0 native replacers set state_sync_config.static_config.central_sync_client_config to null and configure P2P network_config, but omit a replacer to enable p2p_sync_client_config. The overlay YAML explicitly turns P2P sync on, so native synthesis leaves both sync clients disabled and breaks the load-bearing hybrid test layout once native config is used.
Reviewed by Cursor Bugbot for commit 77abc10. Configure here.
77abc10 to
d96316b
Compare



Under the native config path an overlay's config comes from sequencer_config.jsonnet
layers (YAML sequencerConfig is ignored). The testing/node-0 and testing/all-constructs
overlays (synthed by the cdk8s-test and hybrid-system-test CI jobs) had no native layer,
so native synth aborted on unconditionally-read overrides.* keys (validator_id, the outer
committer cache_size, ...).
YAML sequencerConfig). It is deployed live by hybrid_system_test, so values are
load-bearing; guarded by a strict mirror test (test_node0_layer_jsonnet_mirrors_combined_yaml).
overrides.* reads the base layer does not provide, with clearly-dummy immaterial values
(its synth is only kubectl-validated for manifest structure); guarded by a synth-success
test (test_all_constructs_native_config_synthesizes).
This lets every CI-synthed overlay build under native, before the default flip.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com