Skip to content

deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/testing-overlays-native-layersfrom
nimrod/jsonnet/retire-preset-config-path
Open

deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/testing-overlays-native-layersfrom
nimrod/jsonnet/retire-preset-config-path

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:

  • Delete the --config_format container arg (pod_builder) and the whole config_format
    plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
    constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
    the Rust node's parser, so emitting it to the container made the node panic on an
    unknown arg; the node now receives only --config_file. Verified by running the node
    on a synthesized native ConfigMap (reaches 'Finished loading configuration').
  • Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
    machinery (loaders.py); ConfigMap is always built via build_native_config.
  • Remove the two preset-parity python tests + their preset-only helpers; keep all native
    mirror/deep-merge/port tests.

All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 0df4a4a to a07b98f Compare June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 39a3bb3 to e704bbc Compare June 28, 2026 10:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from e704bbc to b9c5305 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a07b98f to a3d7879 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from b9c5305 to 66a55ac Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a3d7879 to 4dfdb44 Compare June 28, 2026 14:04
@cursor

cursor Bot commented Jun 29, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large deletion of deployment config validation (placeholder/YAML parity) and a behavior change for every synthesized sequencer workload; misconfigured overlays now fail at jsonnet build time rather than preset validation.

Overview
Makes jsonnet native the only sequencer CDK8s config path and aligns synthesized pods with the Rust node CLI (no --config_format).

Removes the --config-format CLI flag and stops threading config_format through chart/construct constructors. ConfigMaps are always built via build_native_config; the preset branch (NodeConfigLoader, $$$ placeholder fill, YAML sequencerConfig overrides) is deleted from loaders.py. Pod args now pass only --config_file paths, since the node parser no longer accepts a format flag.

Doc/comments in native.py and secret.py are updated to reflect the single native path.

Reviewed by Cursor Bugbot for commit cbd3f8a. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d8d1348. Configure here.

Comment thread deployments/sequencer/src/constructs/helpers/pod_builder.py
… preset config path

Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
- Delete the --config_format container arg (pod_builder) and the whole config_format
  plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
  constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
  the Rust node's parser, so emitting it to the container made the node panic on an
  unknown arg; the node now receives only --config_file. Verified by running the node
  on a synthesized native ConfigMap (reaches 'Finished loading configuration').
- Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
  machinery (loaders.py); ConfigMap is always built via build_native_config.
- Remove the two preset-parity python tests + their preset-only helpers; keep all native
  mirror/deep-merge/port tests.

All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants