deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646
Conversation
0df4a4a to
a07b98f
Compare
39a3bb3 to
e704bbc
Compare
e704bbc to
b9c5305
Compare
a07b98f to
a3d7879
Compare
b9c5305 to
66a55ac
Compare
a3d7879 to
4dfdb44
Compare
PR SummaryMedium Risk Overview Removes the Doc/comments in Reviewed by Cursor Bugbot for commit cbd3f8a. Bugbot is set up for automated code reviews on this repo. Configure here. |
4dfdb44 to
d8d1348
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d8d1348. Configure here.
… preset config path
Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
- Delete the --config_format container arg (pod_builder) and the whole config_format
plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
the Rust node's parser, so emitting it to the container made the node panic on an
unknown arg; the node now receives only --config_file. Verified by running the node
on a synthesized native ConfigMap (reaches 'Finished loading configuration').
- Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
machinery (loaders.py); ConfigMap is always built via build_native_config.
- Remove the two preset-parity python tests + their preset-only helpers; keep all native
mirror/deep-merge/port tests.
All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
77abc10 to
d96316b
Compare
d8d1348 to
cbd3f8a
Compare


Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
the Rust node's parser, so emitting it to the container made the node panic on an
unknown arg; the node now receives only --config_file. Verified by running the node
on a synthesized native ConfigMap (reaches 'Finished loading configuration').
machinery (loaders.py); ConfigMap is always built via build_native_config.
mirror/deep-merge/port tests.
All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com