apollo_deployments: retire dead preset/replacer generation machinery#14647
Conversation
89ab258 to
c0351e0
Compare
0df4a4a to
a07b98f
Compare
a07b98f to
a3d7879
Compare
4f5f772 to
ece79f9
Compare
PR SummaryLow Risk Overview Deletes the
Reviewed by Cursor Bugbot for commit 06cdd84. Bugbot is set up for automated code reviews on this repo. Configure here. |
4dfdb44 to
d8d1348
Compare
ece79f9 to
3be73e0
Compare
Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so the preset-replacer GENERATION machinery is dead. Remove it: - Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep). - service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/ prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's exclusion set). - Delete the 3 migration guard tests (deployment_files_are_up_to_date, replacer_config_entries_are_in_config, duplicate_config_entries). Keep the build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards, and get_component_configs. The cdk8s configList field is presence-checked only (its targets live in a different directory and are not read under native), so deleting the base replacer JSONs leaves synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d8d1348 to
cbd3f8a
Compare
3be73e0 to
06cdd84
Compare

Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so
the preset-replacer GENERATION machinery is dead. Remove it:
deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep).
prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep
KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's
exclusion set).
replacer_config_entries_are_in_config, duplicate_config_entries). Keep the
build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards,
and get_component_configs.
The cdk8s configList field is presence-checked only (its targets live in a different
directory and are not read under native), so deleting the base replacer JSONs leaves
synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com