apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648
Conversation
89ab258 to
c0351e0
Compare
84755fc to
3c4b392
Compare
3c4b392 to
dbff560
Compare
4f5f772 to
ece79f9
Compare
dbff560 to
16c545d
Compare
PR SummaryMedium Risk Overview The large Reviewed by Cursor Bugbot for commit 06d2a21. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 16c545d. Configure here.
ece79f9 to
3be73e0
Compare
16c545d to
6bc770e
Compare
…from secrets schema, drop value config schema private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime, removing the runtime dependency on both. Delete the value config_schema.json (4147 lines) and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile. Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and split the up-to-date guard to assert only the secrets schema. A transient equivalence test (private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later SerializeConfig/CONFIG_POINTERS teardown. config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and apollo_deployments 9/9 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3be73e0 to
06cdd84
Compare
6bc770e to
06d2a21
Compare


private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.
config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com