apollo_deployments: delete base app_configs and the preset-parity test machinery#14649
Conversation
a4eefa9 to
ec8f72b
Compare
3c4b392 to
dbff560
Compare
9ecf4fe to
e84d1fc
Compare
PR SummaryMedium Risk Overview Strips the machinery that kept those files in sync: Unchanged: jsonnet Reviewed by Cursor Bugbot for commit ea76f65. Bugbot is set up for automated code reviews on this repo. Configure here. |
e84d1fc to
970c001
Compare
16c545d to
6bc770e
Compare
…t machinery
jsonnet build() is the sole source of the node config, so the committed base
app_configs/*_config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *_config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config_{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_*_deserializes + *_infra_matches_rust guards (later phases own those).
apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
970c001 to
ea76f65
Compare

jsonnet build() is the sole source of the node config, so the committed base
app_configs/config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_deserializes + *_infra_matches_rust guards (later phases own those).
apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com