Skip to content

apollo_deployments: delete base app_configs and the preset-parity test machinery#14649

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/source-private-params-from-secrets-schemafrom
nimrod/jsonnet/delete-base-app-configs
Open

apollo_deployments: delete base app_configs and the preset-parity test machinery#14649
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/source-private-params-from-secrets-schemafrom
nimrod/jsonnet/delete-base-app-configs

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

jsonnet build() is the sole source of the node config, so the committed base
app_configs/config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config
{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build
_deserializes + *_infra_matches_rust guards (later phases own those).

apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 29, 2026 11:25
@cursor

cursor Bot commented Jun 29, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large deletion of committed default config snapshots and their guard test; runtime defaults now depend entirely on jsonnet build() unless replacers cover gaps.

Overview
Removes the committed base resources/app_configs/*_config.json snapshots (21 files) now that jsonnet build() is the sole applicative config source.

Strips the machinery that kept those files in sync: test_applicative_matches_app_configs, applicative_matches_app_configs, merged_app_configs / non_default_paths, KEYS_TO_BE_REPLACED, BASE_APP_CONFIGS_DIR_PATH, ComponentConfigInService::get_component_config_*, and is_path_prefix in test utils. Drops the unused phf dependency and AsRefStr on ComponentConfigInService.

Unchanged: jsonnet replacer_* app_configs (still referenced by deployment replacer manifests), plus build_*_deserializes and *_infra_matches_rust parity tests.

Reviewed by Cursor Bugbot for commit ea76f65. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from e84d1fc to 970c001 Compare July 1, 2026 08:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 16c545d to 6bc770e Compare July 1, 2026 08:25
…t machinery

jsonnet build() is the sole source of the node config, so the committed base
app_configs/*_config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *_config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config_{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_*_deserializes + *_infra_matches_rust guards (later phases own those).

apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants