Skip to content

apollo_deployments: delete Rust component-config topology mirror#14688

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/build-component-configsfrom
nimrod/jsonnet/delete-get-component-configs
Draft

apollo_deployments: delete Rust component-config topology mirror#14688
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/build-component-configsfrom
nimrod/jsonnet/delete-get-component-configs

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Now that the integration-test harness sources component configs from jsonnet
build(), remove get_component_configs and everything that existed only to serve
it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the
ScalePolicy module, per-service config builders, the mirror-parity tests and
their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Now that the integration-test harness sources component configs from jsonnet
build(), remove get_component_configs and everything that existed only to serve
it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the
ScalePolicy module, per-service config builders, the mirror-parity tests and
their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Artifacts upload workflows:

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants