apollo_deployments: delete Rust component-config topology mirror#14688
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
Now that the integration-test harness sources component configs from jsonnet build(), remove get_component_configs and everything that existed only to serve it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the ScalePolicy module, per-service config builders, the mirror-parity tests and their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 2, 2026
|
Artifacts upload workflows: |
This was referenced Jul 2, 2026
Open
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now that the integration-test harness sources component configs from jsonnet
build(), remove get_component_configs and everything that existed only to serve
it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the
ScalePolicy module, per-service config builders, the mirror-parity tests and
their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com