Skip to content

bench_tools: delete dead code (unsure, review carefully) #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asaf-sw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bench_tools: delete dead code (unsure, review carefully) #14695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions crates/bench_tools/src/types/benchmark_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ pub struct BenchmarkConfig {
}

impl BenchmarkConfig {
/// Get the full cargo bench command as owned strings.
pub fn cmd_args_owned(&self) -> Vec<String> {
self.cmd_args.iter().map(|s| s.to_string()).collect()
}

/// Check if this benchmark requires input files.
pub fn needs_inputs(&self) -> bool {
self.input_dir.is_some()
Expand Down
Loading