chore(blockifier_test_utils): implement download_cairo_package

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 2 dependent PRs (#5588 , #5593 )
• chore(blockifier_test_utils): implement verify_cairo1_package #5586
• chore(blockifier_test_utils): implement download_cairo_package #5585 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-04-05T12:17:35Z
• Started at 2025-04-05T12:28:09Z
• Started at 2025-04-05T19:45:16Z
• Started at 2025-04-07T07:38:58Z
• Started at 2025-04-07T07:57:39Z
• Started at 2025-04-07T09:15:57Z

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.698 ms 35.207 ms 35.791 ms]
change: [+1.4532% +3.0617% +4.8658%] (p = 0.00 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
2 (2.00%) high mild
10 (10.00%) high severe

[giladchase]

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

---

crates/blockifier_test_utils/Cargo.toml line 12 at r1 (raw file):

cairo_native = []

[dependencies]

If you want, I think you can Command curl and tar, since we already guarantee through dependencies.sh that the former is installed, and the latter is installed by default.
Motivation: three new deps might be a bit pricey for a test-utils crate (that other crates require during testing), especially if they're single use. Using curl/tar should keep compilation-time unchanged,

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.052 ms 35.521 ms 36.071 ms]
change: [+2.1391% +3.6462% +5.2411%] (p = 0.00 < 0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) high mild
8 (8.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [30.667 ms 30.765 ms 30.903 ms]
change: [+1.1056% +1.4693% +1.9070%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe

[dorimedini-starkware]

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

---

crates/blockifier_test_utils/Cargo.toml line 12 at r1 (raw file):

Previously, giladchase wrote…

If you want, I think you can Command curl and tar, since we already guarantee through dependencies.sh that the former is installed, and the latter is installed by default.
Motivation: three new deps might be a bit pricey for a test-utils crate (that other crates require during testing), especially if they're single use. Using curl/tar should keep compilation-time unchanged,

IDK, using rust crates at least looks cleaner; and shouldn't we be writing towards the glorious day when we build a single project and run all tests once, with good caching?

[RoeiE-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul, @giladchase, and @noaov1)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 67 at r4 (raw file):

    let filename = "release-x86_64-unknown-linux-musl.tar.gz";
    let package_url =
        format!("https://github.com/starkware-libs/cairo/releases/download/v{version}/{filename}");

As this can be a general function to download artifacts from GH, I think package_url, filename and maybe directory should be input parameters and not constants.

[dorimedini-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul, @giladchase, @noaov1, and @RoeiE-starkware)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 67 at r4 (raw file):

Previously, RoeiE-starkware wrote…

As this can be a general function to download artifacts from GH, I think package_url, filename and maybe directory should be input parameters and not constants.

in this context it is highly specific to cairo packages; only the cairo compiler version should be input.
a "general url" util would be unsafe, no?
where else in our code do we download files via URL? if we have other locations I can share code

[giladchase]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul, @noaov1, and @RoeiE-starkware)

---

crates/blockifier_test_utils/Cargo.toml line 12 at r1 (raw file):

Previously, dorimedini-starkware wrote…

IDK, using rust crates at least looks cleaner; and shouldn't we be writing towards the glorious day when we build a single project and run all tests once, with good caching?

Can you clr this with Lior? AFAIK he's against single-use ext deps, and here each dep is 1/3-use 😅

Also, it's not just about compilation caching, there is also:

1. potential for breakage (which does happen on cargo due to semver adherenece)
2. linking time: we area already forced to use lld due to our irregularly inflated dep-tree, we want to minimize the issue and hopefully not have to use this linker anymore (until it's added to stable rust I guess).

[dorimedini-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul, @giladchase, @noaov1, and @RoeiE-starkware)

---

crates/blockifier_test_utils/Cargo.toml line 12 at r1 (raw file):

Previously, giladchase wrote…

Can you clr this with Lior? AFAIK he's against single-use ext deps, and here each dep is 1/3-use 😅

Also, it's not just about compilation caching, there is also:

1. potential for breakage (which does happen on cargo due to semver adherenece)
2. linking time: we area already forced to use lld due to our irregularly inflated dep-tree, we want to minimize the issue and hopefully not have to use this linker anymore (until it's added to stable rust I guess).

Lior is in favor of curl + tar, making the change :)

[giladchase]

Reviewed 1 of 3 files at r1, 2 of 2 files at r5.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul, @noaov1, and @RoeiE-starkware)

d

[dorimedini-starkware]

Reviewed 2 of 3 files at r9, 1 of 1 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

[dorimedini-starkware]

Reviewed 2 of 3 files at r12, 1 of 1 files at r13, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)