chore(blockifier_test_utils): extract logic into starknet_sierra_compile

[dorimedini-starkware]

No description provided.

[dorimedini-starkware]

• chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 2 dependent PRs (#5588 , #5593 ) 👈 (View in Graphite)
• chore(blockifier_test_utils): implement verify_cairo1_package #5586
• chore(blockifier_test_utils): implement download_cairo_package #5585
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[giladchase]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 191 at r1 (raw file):

    sierra_compile_command.args([
        "starknet-sierra-compile",
        path.as_str(),

nit
(also for consistency with sn_compile above)

Suggestion:

    &path,

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @elintul, @giladchase, and @noaov1)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 191 at r1 (raw file):

Previously, giladchase wrote…

nit
(also for consistency with sn_compile above)

lol done

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

[github-actions]

Artifacts upload workflows:

• Started at 2025-04-27T10:30:19Z

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.267 ms 30.316 ms 30.368 ms]
change: [-1.6937% -1.3503% -1.0354%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @elintul and @noaov1)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 148 at r3 (raw file):

        format!("--manifest-path={}/Cargo.toml", cairo1_compiler_path.to_string_lossy()),
        "--bin".into(),
    ]);

Suggestion:

    verify_cairo1_compiler_deps(git_tag_override);

    let cairo1_compiler_path = local_cairo1_compiler_repo_path();
    

    // Command args common to both compilation phases.
    let mut base_compile_args = vec![
        "run".into(),
        format!("--manifest-path={}/Cargo.toml", cairo1_compiler_path.to_string_lossy()),
        "--bin".into(),
    ]);

---

crates/blockifier_test_utils/src/cairo_compile.rs line 169 at r3 (raw file):

}

/// Compile Cairo1 Contract into their Sierra version using the compiler version set in the

Suggestion:

// Compiles

---

crates/blockifier_test_utils/src/cairo_compile.rs line 171 at r3 (raw file):

/// Compile Cairo1 Contract into their Sierra version using the compiler version set in the
/// Cargo.toml
pub fn starknet_compile(path: String, base_compile_args: &mut [String]) -> Vec<u8> {

Why is this mutable?

Code quote:

base_compile_args: &mut [String]

---

crates/blockifier_test_utils/src/cairo_compile.rs line 188 at r3 (raw file):

}

/// Compile Sierra code into CASM.

Suggestion:

/// Compiles 

---

crates/blockifier_test_utils/src/cairo_compile.rs line 189 at r3 (raw file):

/// Compile Sierra code into CASM.
fn starknet_sierra_compile(path: String, base_compile_args: &mut Vec<String>) -> Vec<u8> {

Why is this mutable (and why isn't it the same type as in starknet_compile)?

Code quote:

 base_compile_args: &mut Vec<String>

[TzahiTaub]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)