feat(blockifier_test_utils): migrate to new cairo recompilation logic

[dorimedini-starkware]

No description provided.

[dorimedini-starkware]

• chore(blockifier_test_utils): delete tag-and-toolchain related code #5589 : 2 dependent PRs (#5590 , #5591 )
• feat(blockifier_test_utils): migrate to new cairo recompilation logic #5588 👈 (View in Graphite)
• chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 1 other dependent PR (#5593 )
• chore(blockifier_test_utils): implement verify_cairo1_package #5586
• chore(blockifier_test_utils): implement download_cairo_package #5585
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[TzahiTaub]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @elintul, @giladchase, and @noaov1)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 137 at r2 (raw file):

    let (tag, _cairo_repo_path) = get_tag_and_repo_file_path(git_tag_override);
    let version = tag.strip_prefix("v").unwrap().to_string();
    assert!(cairo1_package_exists(&version));

Why aren't you calling verify_cairo1_package instead? Is making this function async a problem?

Code quote:

 assert!(cairo1_package_exists(&version));

---

crates/blockifier_test_utils/src/cairo_compile.rs line 153 at r2 (raw file):

/// Compiles Cairo1 Contract into their Sierra version using the given compiler version.
/// Assumes the relevant compiler version is already downloaded.

Suggestion:

/// Compiles Cairo1 contracts into their Sierra version using the given compiler version.
/// Assumes the relevant compiler version was already downloaded.

---

crates/blockifier_test_utils/src/cairo_compile.rs line 163 at r2 (raw file):

/// Compiles Sierra code into CASM using the given compiler version.
/// Assumes the relevant compiler version is already downloaded.

Suggestion:

version was already downloaded.

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 98 at r2 (raw file):

                    .unwrap()
                    .to_string();
                verify_cairo1_package(&version).await;

If you add this to the code in the other file it can be removed from here.

Code quote:

 verify_cairo1_package(&version).await;

[dorimedini-starkware]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @elintul, @giladchase, @noaov1, and @TzahiTaub)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 137 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Why aren't you calling verify_cairo1_package instead? Is making this function async a problem?

1. yes
2. the package is verified before calling this function

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 98 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

If you add this to the code in the other file it can be removed from here.

I don't want to make the compile function async

---

crates/blockifier_test_utils/src/cairo_compile.rs line 153 at r2 (raw file):

/// Compiles Cairo1 Contract into their Sierra version using the given compiler version.
/// Assumes the relevant compiler version is already downloaded.

Done.

---

crates/blockifier_test_utils/src/cairo_compile.rs line 163 at r2 (raw file):

/// Compiles Sierra code into CASM using the given compiler version.
/// Assumes the relevant compiler version is already downloaded.

Done.

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul, @giladchase, and @noaov1)