chore(blockifier_test_utils): delete tag-and-toolchain related code

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• chore(blockifier_test_utils): delete tag-and-toolchain related code #5589 : 2 dependent PRs (#5590 , #5591 ) 👈 (View in Graphite)
• feat(blockifier_test_utils): migrate to new cairo recompilation logic #5588
• chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 1 other dependent PR (#5593 )
• chore(blockifier_test_utils): implement verify_cairo1_package #5586
• chore(blockifier_test_utils): implement download_cairo_package #5585
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TzahiTaub]

Reviewed 3 of 3 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @elintul, @giladchase, and @noaov1)

---

crates/blockifier_test_utils/src/contracts.rs line 203 at r3 (raw file):

            Self::LegacyTestContract => LEGACY_CONTRACT_COMPILER_VERSION.into(),
            Self::CairoStepsTestContract => CAIRO_STEPS_TEST_CONTRACT_COMPILER_VERSION.into(),
            _ => cairo1_compiler_version(),

This is what will be returned for Cairo0 contracts right? like SecurityTests`. Please return Cairo0 compiler version, even if this function is not expected to be called by such.

Code quote:

  _ => cairo1_compiler_version(),

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 94 at r3 (raw file):

                for contract in feature_contracts
                    .into_iter()
                    .filter(|contract| contract.cairo_version() == cairo_version)

This is redundant (unless cairo1_feature_contracts_by_version has a bug, which in this case - we hide it)

Code quote:

  .filter(|contract| contract.cairo_version() == cairo_version)

[TzahiTaub]

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware, @elintul, @giladchase, and @noaov1)

[dorimedini-starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @elintul, @giladchase, @noaov1, and @TzahiTaub)

---

crates/blockifier_test_utils/src/contracts.rs line 203 at r3 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

This is what will be returned for Cairo0 contracts right? like SecurityTests`. Please return Cairo0 compiler version, even if this function is not expected to be called by such.

this is only for cairo1, meaningless for cairo0. I'll panic explicitly if this is not the case...

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 94 at r3 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

This is redundant (unless cairo1_feature_contracts_by_version has a bug, which in this case - we hide it)

fixed here (right?)

[TzahiTaub]

Reviewed 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @elintul, @giladchase, and @noaov1)

---

crates/blockifier_test_utils/src/contracts.rs line 203 at r3 (raw file):

Previously, dorimedini-starkware wrote…

this is only for cairo1, meaningless for cairo0. I'll panic explicitly if this is not the case...

OK, can you add this to the doc as well?

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 94 at r3 (raw file):

Previously, dorimedini-starkware wrote…

fixed here (right?)

Yep

[TzahiTaub]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul, @giladchase, and @noaov1)