feat(blockifier_test_utils): download compilers (async), then recompile all (async)

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(blockifier_test_utils): update CI for cairo recompilation #5594
• chore(blockifier_test_utils): delete dead code #5592
• feat(blockifier_test_utils): download compilers (async), then recompile all (async) #5591 👈 (View in Graphite)
• chore(blockifier_test_utils): delete tag-and-toolchain related code #5589 : 1 other dependent PR (#5590 )
• feat(blockifier_test_utils): migrate to new cairo recompilation logic #5588
• chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 1 other dependent PR (#5593 )
• chore(blockifier_test_utils): implement verify_cairo1_package #5586
• chore(blockifier_test_utils): implement download_cairo_package #5585
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 101 at r1 (raw file):

                FeatureContract::cairo1_feature_contracts_by_version()
            {
                for contract in feature_contracts

note that now we don't recompile in 3 batches (one batch per compiler version) - all are compiled in parallel, using different binaries.

Code quote:

            for (_version, feature_contracts) in
                FeatureContract::cairo1_feature_contracts_by_version()
            {
                for contract in feature_contracts

[TzahiTaub]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @elintul and @noaov1)

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 95 at r2 (raw file):

            info!("Done spawning tasks for package downloads. Awaiting them...");
            download_task_set.join_all().await;
            info!("Done downloading packages.");

I think the logs will be confusing. We will get a "spawning" log and "done downloading" log even if all packages existed and we didn't download anything. I see the download_cairo_package has its own "Downloading" log, so I think we can just remove all of the logs in the current function. Optionally, we can collect the versions and print them once - something like:

Suggestion:

            {
                download_task_set.spawn(async move { verify_cairo1_package(&version).await });
            }
            info!("Verifying Cairo1 packages for versions {}.", FeatureContract::cairo1_feature_contracts_by_version().keys());
            download_task_set.join_all().await;
            info!("Cairo1 packages verified");
            

[TzahiTaub]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @elintul, and @noaov1)

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @elintul, @noaov1, and @TzahiTaub)

---

crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs line 95 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I think the logs will be confusing. We will get a "spawning" log and "done downloading" log even if all packages existed and we didn't download anything. I see the download_cairo_package has its own "Downloading" log, so I think we can just remove all of the logs in the current function. Optionally, we can collect the versions and print them once - something like:

Done.

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)