Skip to content

feat(blockifier_test_utils): download compilers (async), then recompile all (async) #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorimedini-starkware merged 1 commit into from
May 4, 2025
Merged

feat(blockifier_test_utils): download compilers (async), then recompile all (async) #5591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions crates/blockifier_test_utils/tests/feature_contracts_compatibility_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,24 @@ async fn verify_feature_contracts_compatibility(fix: bool, cairo_version: CairoV
}
}
CairoVersion::Cairo1(RunnableCairo1::Casm) => {
for (version, feature_contracts) in
// Prepare cairo packages.
let mut download_task_set = tokio::task::JoinSet::new();
for (version, _feature_contracts) in
FeatureContract::cairo1_feature_contracts_by_version()
{
download_task_set.spawn(async move { verify_cairo1_package(&version).await });
}
info!(
"Verifying Cairo1 packages for versions {:?}.",
FeatureContract::cairo1_feature_contracts_by_version().keys()
);
download_task_set.join_all().await;
info!("Cairo1 packages verified.");
// Verify feature contracts.
let mut task_set = tokio::task::JoinSet::new();
for (_version, feature_contracts) in
FeatureContract::cairo1_feature_contracts_by_version()
{
verify_cairo1_package(&version).await;

let mut task_set = tokio::task::JoinSet::new();

for contract in feature_contracts
.into_iter()
.filter(|contract| contract.cairo_version() == cairo_version)
Expand All @@ -97,10 +108,10 @@ async fn verify_feature_contracts_compatibility(fix: bool, cairo_version: CairoV
task_set
.spawn(verify_feature_contracts_compatibility_logic_async(contract, fix));
}
info!("Done spawning tasks for {version:?}. Awaiting them...");
task_set.join_all().await;
info!("Done awaiting tasks for {version:?}.");
}
info!("Done spawning tasks for contract compilation. Awaiting them...");
task_set.join_all().await;
info!("Done awaiting tasks for contract compilation.");
}
#[cfg(feature = "cairo_native")]
CairoVersion::Cairo1(RunnableCairo1::Native) => {
Expand Down